Fix: Prevent unnecessary docs.json updates when content unchanged#30
Merged
Fix: Prevent unnecessary docs.json updates when content unchanged#30
Conversation
- Compare actual data structures instead of string representations - Preserve existing file's trailing newline convention - Show friendly '✨ No changes needed' message when content is already up to date - Fixes #29: avoids creating PRs that only add newlines
zzstoatzz
force-pushed
the
fix-issue-29
branch
from
626413b to
78741b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29
Summary
This PR addresses the issue where mdxify would create PRs that only add newlines to docs.json, even when the actual content hasn't changed.
Changes
Test Plan
Tested locally by running mdxify multiple times on the same codebase - the second run correctly reports 'No changes needed' instead of writing an identical file with potentially different formatting.