[AutoPR-agrifood]autogenerated #66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove circular refs of eventHubBufferedProducerClient -> index -> eventHubBufferedProducerClient - remove circular refs of eventData -> eventDataBatch -> eventData - suppress circular refs from dependency `rhea-promise`
### Packages impacted by this PR digital-twins-core iot-modelsrepository ### Issues associated with this PR Azure#21199 ### Describe the problem that is addressed by this PR Now that @azure/core-tracing has GA'd we are upgrading all our packages to the latest APIs. For iot-modelsrepository there was minimal changes as this package isn't even using tracing. For digital-twins there were more involved changes to test files and source files.
### Packages impacted by this PR @@azure/core-lro ### Issues associated with this PR ### Describe the problem that is addressed by this PR lroEngine provides a default implementation of client-side polling for LROs and the default cancellation method is a no-op. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? This PR makes cancellation configurable by adding an optional function that specifies how cancellation should work. Currently, cancellation requests are not standardized according to the [REST API spec](https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#long-running-operations--jobs) so I am not sure if we could provide a reasonable default implementation. ### Are there test cases added in this PR? _(If not, why?)_ N/A ### Provide a list of related PRs _(if any)_ N/A ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
…zure#21866) The live test logs shows that under some circumstance `this.receiver` could be `undefined`. We do have code to clean up the timer already so that might have happened before the clean up and after receiver is closed. ``` Uncaught TypeError: Cannot read properties of undefined (reading 'address') at Receiver.get address [as address] (/Users/runner/work/1/s/common/temp/node_modules/.pnpm/[email protected]/node_modules/rhea-promise/lib/link.ts:96:24) at Timeout._onTimeout (/Users/runner/work/1/s/sdk/core/core-amqp/src/requestResponseLink.ts:158:39) at listOnTimeout (node:internal/timers:559:17) at processTimers (node:internal/timers:502:7) ``` This PR ensures that we don't throw when `this.receiver` is undefined. The address is only used in logging.
…re#21864) There's a recent change in Blob SDK that empty metadata is now returned as `undefined` (issue# 21863). This PR adds a guard against undefined metadata so we don't try to access property off `undefined`.
…zure#21869) This is consistent with most of other packages in the repo. Version 1.2.2 is never released, and we already bumped the version to 1.3.0
…re#21868) Co-authored-by: Ben Broderick Phillips <[email protected]>
…e#21873) * clean slate * [Text Analytics] Scaling @azure/ai-text-analytics, Part I (Azure#21417) # Scaling @azure/ai-text-analytics, Part I This PR reimplements a subset of the public API of the Text Analytics library in a way that avoids the method explosion and the discoverability problems described in https://gist.github.com/deyaaeldeen/40badd8f0460a9a3cd5965b1e4d14adf ## Design Highlights ### One `analyze` to rule them all https://github.com/Azure/azure-sdk-for-js/blob/23e0919ae7a557a112715a2dbceb0c58a62fde2e/sdk/textanalytics/ai-text-analytics/samples/v5/javascript/analyzeSentimentWithOpinionMining.js#L56-L58 becomes https://github.com/Azure/azure-sdk-for-js/blob/23e0919ae7a557a112715a2dbceb0c58a62fde2e/sdk/textanalytics/ai-text-analytics/samples/v6-beta/javascript/opinionMining.js#L54-L58 Notice that the type of the action is no longer a standalone method but rather an input to the `analyze` method. Demo: https://user-images.githubusercontent.com/6074665/163894076-745be9cb-651a-42da-94d8-c299a44fa0d1.mp4 ### Model version and top-level statistics in the response are no longer exposed but still accessible Model version and top-level statistics are part of the response object and v5 exposes them in the response arrays by attaching them to the array object itself. This works fine but it caused our [documentation to look like that `Array` is part of the client types](https://docs.microsoft.com/en-us/javascript/api/@azure/ai-text-analytics/detectlanguageresultarray?view=azure-node-latest):  They're removed in this design but they can still be accessed as follows: https://github.com/Azure/azure-sdk-for-js/blob/23e0919ae7a557a112715a2dbceb0c58a62fde2e/sdk/textanalytics/ai-text-analytics/samples/v6-beta/javascript/stats.js#L29-L45 ### A batching analyze Coming soon in a PR near you! * [Text Analytics] Scaling @azure/ai-text-analytics, Part II (Azure#21768) # Scaling @azure/ai-text-analytics, Part II This PR reimplements a subset of the public API of the Text Analytics library in a way that avoids the method explosion and the discoverability problems described in https://gist.github.com/deyaaeldeen/40badd8f0460a9a3cd5965b1e4d14adf ## Design Highlights ### `beginAnalyzeBatch` is the new method to batch actions [Sample call](https://github.com/deyaaeldeen/azure-sdk-for-js/blob/textanalytics/beginAnalyzeBatch/sdk/textanalytics/ai-text-analytics/samples-dev/batching.ts): ```js const poller = await client.beginAnalyzeBatch( [ { kind: "EntityRecognition", modelVersion: "latest", }, { kind: "PiiEntityRecognition", modelVersion: "latest", }, { kind: "KeyPhraseExtraction", modelVersion: "latest", }, ], documents, "en" ); ``` ### `FHIR` support [Sample call](https://github.com/deyaaeldeen/azure-sdk-for-js/blob/textanalytics/beginAnalyzeBatch/sdk/textanalytics/ai-text-analytics/samples-dev/healthcare.ts): ```js const poller = await client.beginAnalyzeBatch( [ { kind: "Healthcare", fhirVersion: "4.0.1", }, ], documents ); ``` ### Poller rehydration story [Sample call](https://github.com/deyaaeldeen/azure-sdk-for-js/blob/textanalytics/beginAnalyzeBatch/sdk/textanalytics/ai-text-analytics/samples-dev/rehydratePolling.ts): ```js const rehydratedPoller = await client.restoreAnalyzeBatchPoller(serializedState); ``` ### Cancellation support `poller.cancel()` actually sends a cancellation request. To enable this, `@azure/core-lro`'s `lroEngine` now supports cancellation. ### Paging from specific continuation tokens [Sample call](https://github.com/deyaaeldeen/azure-sdk-for-js/blob/textanalytics/beginAnalyzeBatch/sdk/textanalytics/ai-text-analytics/samples-dev/paging.ts): ```js for await (const page of actionResults.byPage({ maxPageSize: 1, continuationToken, })) { // do something } ```
* Update customization doc structure * Update docs * Update the customization doc to the latest * Update docs * Update folder
Post release automated changes for azure-arm-datafactory
…zure#21850) This is to work around a service issue when receiving messages from start position of -1. Similar to PR Azure#20982
…#21892) The compiler is having problem figuring it out in latest rush update --full run.
* [core] Fix link in README * Update sdk/core/README.md Co-authored-by: Jeff Fisher <[email protected]> Co-authored-by: Jeff Fisher <[email protected]>
* Generated functionality for Operator Connect MVP0. * Reverting unwanted changes in arm-appservice * Updated SDK version. * Added entry to changelog. * Added new recordings * Fixing tests. * Fixing tests. * Fixing AAD test. * Modified recordings to address PR comments * Fixed version in changelog. * Fixing package version. * Revert "Fixing package version." This reverts commit cb6312b. * Added tag to beta as unreleased * Reapplying fix of version to alpha * Fixing package version.
- for eslint-plugin-azure-sdk and service-bus - remove unused `glob` dependencies from core-http
- eslint to ^8.0.0 - @types/eslint to ~8.4.0 - @typescript-eslint plugins to ~5.22.0 * Fix broken test because of class property node type changes. Improve test a bit to also verifying error line and column numbers * Disable @typescript-eslint/no-invalid-this After upgrading this rule reports more false positives. The following comment on the github issue suggests that it doesn't work for some callbacks because it is just a simple rule that doesn't do type analysis. typescript-eslint/typescript-eslint#3620 (comment) * Fix linter issues after upgrading the plugins in eslint-plugin-azure-sdk. Also upgrade eslint version in the impacted packages
* changes-track2-release * update
* servicelinker-track2-release * update * Update README.md No change required in readme.md Co-authored-by: Mary Gao <[email protected]>
…21893) * [core-lro] Set isCancelled when status is cancelled * don't check for isCanceled in TA test * fix lint * address feedback and handle cancellation uniformly * address feedback * add tests * edit * revert behavioral change * Update sdk/textanalytics/ai-text-analytics/package.json Co-authored-by: Will Temple <[email protected]>
* Update CHANGELOG.md * Update CHANGELOG.md
* modify three files in kusto * modify changelog in kusto * Update CHANGELOG.md Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
* Update dependencies * rush update * Add execute:samples
* [Text Analytics] Update tests * re-record the rehydrated poller test
Post release automated changes for azure-arm-kusto
Co-authored-by: Chidozie Ononiwu <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
* update labservices package * update labservices package Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
* update machinelearningexperimentation package * update machinelearningexperimentation package Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
* fix dependency error in tools/versioning * fix dependency error in tools/dependency-testing
…2323) * Remove execa in tests * format
* release eventgrid package * Fix test case failures Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]> Co-authored-by: Mary Gao <[email protected]>
Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
* release datafactory package * release datafactory package Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
…nMs` (Azure#22343) * Improves documentation for `maxAutoLockRenewalDurationInMs` * Update sdk/servicebus/service-bus/src/models.ts Co-authored-by: Jesse Squire <[email protected]> * Update sdk/servicebus/service-bus/src/models.ts Co-authored-by: Jesse Squire <[email protected]> * Update sdk/servicebus/service-bus/src/models.ts Co-authored-by: Jesse Squire <[email protected]> * Apply suggestions from code review * improve * PR LINK Co-authored-by: Jesse Squire <[email protected]>
Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
…e#22355) Post release automated changes for azure-arm-operationalinsights
* Support local addons path override in stress test deployment * Support username based deployId in local stress deployment * Support WhatIf in stress infrastructure provision script * Simplify stress user detection Co-authored-by: Wes Haggard <[email protected]> * Run helm plugin add with helper * Add WhatIf support to ps module install helper function Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Wes Haggard <[email protected]>
…ues (Azure#22345) * Adds support to run queries with group by over a column with null values * Update CHANGELOG.md * Prettifying the code * Update CHANGELOG.md * Update query.spec.ts
This is a holdover from when we used `createTracingFunction`. Now that this package is using TracingClient, the comment should reflect that.
### Packages impacted by this PR @azure/core-lro ### Issues associated with this PR N/A ### Describe the problem that is addressed by this PR The initial request method for an LRO could be a GET. See https://github.com/Azure/azure-rest-api-specs/blob/main/specification/web/resource-manager/Microsoft.Web/stable/2022-03-01/WebApps.json#L2981 ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? N/A ### Are there test cases added in this PR? _(If not, why?)_ Yes ### Provide a list of related PRs _(if any)_ N/A ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.