Skip to content

Conversation

zzvswxy
Copy link
Owner

@zzvswxy zzvswxy commented Jul 5, 2022

No description provided.

timovv and others added 30 commits May 19, 2022 14:18
* [Text Analytics] Add migration guide

* update link

* update product label

* address feedback

* address feedback
Post release automated changes for azure-service-bus
…1923)

Post release automated changes for azure-arm-containerservice
Post release automated changes for azure-arm-network
Post release automated changes for azure-arm-eventgrid
* appplatform-track2

* update

* update
Post release automated changes for azure-arm-appplatform
…zure#21948)

Previously `npm view <packageName> versions --json` returns an array even when
the result only contains one version.  In latest NPM version in NodeJS v16 the
result is now a string, which isn't expected by `semver` APIs.

This PR wraps the single string result with an array.
* [react-native] Add a basic sample for AppConfiguration

* Apply suggestions from code review

Co-authored-by: Harsha Nalluru <[email protected]>

Co-authored-by: Harsha Nalluru <[email protected]>
This PR fixes broken link verification failure in aggregate reports pipeline.
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
* [Text Analytics] Publishing v6 samples

* update product slugs
* Delete PR and branch which central PR is closed

* more logging changes

* resume the delete operations.

* Change the pr link directly

* fix the regex

* Refactor on regex name

* change the function to inline logic

* change typo

* delete on branch

* make changes on comments

* add commnets

* Update eng/common/scripts/Delete-RemoteBranches.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/scripts/Delete-RemoteBranches.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/scripts/Delete-RemoteBranches.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/scripts/Delete-RemoteBranches.ps1

Co-authored-by: Wes Haggard <[email protected]>

Co-authored-by: sima-zhu <[email protected]>
Co-authored-by: Sima Zhu <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
updated parameter on list keys to get account credentials
* Adding communication email client sdk for js

* Making fixes to resolve pipeline errors

* Removing prepack script

* Adjusting README links

* Updating broken links

* Updating SDK based on swagger changes

* Fix sample formatting

* Update pnpm lock

* Updating README with new swagger destination

* Update CHANGELOG.md

* PR changes

* PR changes

Co-authored-by: Yogesh Mohanraj <[email protected]>
***NO_CI***

Co-authored-by: Wei Jun <[email protected]>

- [x] template

Enable README Eslint (Azure#21612)

* fixed ai-anomaly-detector

* fixed minor error

* fixed app-configuration

* fixed communication-chat

* fixed communication-common

* fixed communication-identity

* fixed communication-network-traversal

* fixed communication-phone-numbers

* fixed communication-short-codes

* fixed communication-sms

* fixed container-registry

* fixed digital-twins-core

* fixed eventgrid

* fixed event-hubs

* fixed ai-form-recognizer

* fixed opentelemetry-instrumentation-azure-sdk

* fixed mixed-reality-authentication

* fixed quantum-jobs

* fixed mixed-reality-remote-rendering

* fixed schema-registry

* fixed service-bus

* fixed storage-blob

* fixed storage-file-datalake

* fixed storage-file-share

* fixed storage-queue

* fixed data-tables

* fixed video-analyzer-edge

* fixed web-pubsub

* fixed web-pubsub-express

* partially fixed attestation

* added target to lint:fix in attestation

* fixed ai-anomaly-detector

* revert attestation

* fixed container-registry

* fixed digital-twins-core

* fixed eventgrid

* fixed opentelemetry-instrumentation-azure-sdk

* fixed mixed-reality-authentication

* fixed mixed-reality-remote-rendering

* storage-blob

* fixed storage-file-datalake

* fixed storage-file-share

* fixed storage-queue

* fixed template

* fixed ai-text-analytics

* fixed schema-registry-arvo

* fixed ai-metric-advisor

* fixed eventhubs-checkpointstore-table

* fixed eventhubs-checkpointstore-blob

* fixed identity-vscode

* fixed identity-cache-persistence

Add `-ext .ts,.javascript,.js` option back

This option is used to specify file patterns under directories. Without it,
unwanted files (e.g., *.json under test folder) will be linted.
* use local config in retry<T>

* format code

* used the spread operator to copy the config
* containerservice-release

* update
…zure#21996)

Post release automated changes for azure-arm-recoveryservicesbackup
kazrael2119 and others added 30 commits June 28, 2022 14:51
* delete valid links in ignore-links.txt

* Update ignore-links.txt

Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
Added myself to the CodeOwners for .github dir as I will be helping @jsquire with GitHub CXP on this repo.
From the tests point of view, the path of the initial request is inconsequential and could be anything. I updated the path property to be optional in `LroResponseSpec` and the implementation defaults it to "path". This simplifies the tests a bit because `path` now doesn't have to be specified in the first item in the routes list.
We had continueOnError set to true so if the emulator failed to start we would still try to run the tests which all fail but take a long time to run.  The timeout for this step is about 10mins of trying so that should be enough time and so we also don't really need another retry step.

Co-authored-by: Wes Haggard <[email protected]>
* Update verify-readme to take a single or multiple paths

* chance ScanPaths to a comma delimited list and coalesce ScanPath/ScanPaths into a single variable for the script

* VS Code was nice enough to add an extra single quote when adding a quote to the end of the line'

* Capture ScanPaths.Split into an array so we don't have to call Split again

Co-authored-by: James Suplizio <[email protected]>
upgrade cosmos with azure core tracing for cosmos diagnostics.
* refresh analysissercices package

* upload yaml

* Update ci.mgmt.yml

Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
* stress test script and docs migration from test to pg cluster

* comments for stress-test-deployment-lib script

Co-authored-by: Albert Cheng <[email protected]>
* release resourceconnector package

* add link in a file

* fix error

Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
* workloads-track2-release

* update

* update pnpm-lock file

* Update tests

* Update sample files

Co-authored-by: zsgwwj <[email protected]>
Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
* [core] Update core-xml to support CDATA
Simplifies the polling logic in the lroEngine by merging the body, location, and passthrough polling algorithms into one. This was done by capturing the essence of each scenario in a configuration bag and providing an explicit and general termination condition in each case. This change eliminates code duplication and provides a precise and simple polling algorithm that follows the [illustrated LRO flowchart](https://microsoft.sharepoint.com/:u:/t/AzureDeveloperExperience/ERFsgxlpa2tBrRKxceLzB8gB_44VE_Gr-dQdCFwvB2h0GQ?e=bHbo2T):

Consider the top right corner that describes sending the final GET request:
![finalGet](https://user-images.githubusercontent.com/6074665/176753403-3b4296f1-b6c9-4318-9835-fab20cb7375c.png)
This is implemented as follows: https://github.com/Azure/azure-sdk-for-js/blob/817c92fa9e946bc661818804566d394c8386a5bf/sdk/core/core-lro/src/lroEngine/impl.ts#L67-L96 For example, there is no such request in the case of a DELETE (line 78-80).

The rest of the chart, mainly the left half:
![scenarios](https://user-images.githubusercontent.com/6074665/176754810-fe201f45-d735-4b47-9b66-67d9f0634415.png)
can be seen implemented naturally in: https://github.com/Azure/azure-sdk-for-js/blob/817c92fa9e946bc661818804566d394c8386a5bf/sdk/core/core-lro/src/lroEngine/impl.ts#L98-L134 For example, the initial response for a PUT LRO without an operation location header polls from the request URL (lines 124-128).

Now termination can easily be checked as follows: https://github.com/Azure/azure-sdk-for-js/blob/817c92fa9e946bc661818804566d394c8386a5bf/sdk/core/core-lro/src/lroEngine/impl.ts#L191-L213

Note that there is a change in behavior where some previously thrown errors are no longer thrown. For context, the engine used to throw an error if the status code of the polling response is _weird_. For example, receiving a 204 from polling a resource location is weird. However, throwing an error in this case doesn't make the customer experience any better. The change is to throw errors for >=400 status codes only.
* Update reamde credential parts

* Update typo

* Update typo
* refresh managementpartner package

* update files

* Update package.json

* Update aCEProvisioningManagementPartnerAPI.ts

* update files

* regenerate managementpartner

Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
…22426)

Post release automated changes for azure-arm-managementpartner
* refresh migrate package

* refresh migrate package

* fix changelog

* Update CHANGELOG.md

Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
Post release automated changes for azure-arm-migrate
* update policy package

* update policy package

* update policy package

* Update policy_examples.ts

* Update policy_examples.ts

* Update policy_examples.ts

* update files

* update files

* delete sample folder

* generate sample folder

Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
* refresh storageimportexport package

* update files

Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
Post release automated changes for azure-arm-policy
* refresh support package

* update files

Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
…e#22443)

Post release automated changes for azure-arm-storageimportexport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.