Skip to content

fix(cli): surface swallowed errors in locks module #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xAxiom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): surface swallowed errors in locks module #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions CLI/src/core/locks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,13 @@ export function acquireLock(runId: string, command: string): boolean {
// Stale lock - process is dead, remove it
logger.warn(`Removing stale lock from dead process ${lockInfo.pid}`);
fs.unlinkSync(lockPath);
} catch {
} catch (err) {
// Corrupted lock file, remove it
logger.warn('Removing corrupted lock file');
logger.warn(`Removing corrupted lock file: ${err}`);
try {
fs.unlinkSync(lockPath);
} catch {
// Ignore
} catch (unlinkErr) {
logger.warn(`Failed to remove corrupted lock file: ${unlinkErr}`);
}
}
}
Expand Down Expand Up @@ -115,8 +115,8 @@ export function releaseLock(): void {
logger.debug('Lock released');
}
}
} catch {
// Ignore errors during cleanup
} catch (err) {
logger.warn(`Failed to release lock during cleanup: ${err}`);
}
}

Expand All @@ -131,8 +131,8 @@ export function getLockInfo(): LockInfo | null {
const lockContent = fs.readFileSync(lockPath, 'utf-8');
return JSON.parse(lockContent) as LockInfo;
}
} catch {
// Ignore
} catch (err) {
logger.warn(`Failed to read lock file: ${err}`);
}

return null;
Expand Down
Loading