Skip to content

Update nix package and add CI step to ensure it always builds - #170

Open
jcmuller wants to merge 2 commits into
0xjuanma:mainfrom
jcmuller:jcmuller/push-xwukkpsypzws
Open

Update nix package and add CI step to ensure it always builds#170
jcmuller wants to merge 2 commits into
0xjuanma:mainfrom
jcmuller:jcmuller/push-xwukkpsypzws

Conversation

@jcmuller

Copy link
Copy Markdown
Contributor

No description provided.

@jcmuller
jcmuller force-pushed the jcmuller/push-xwukkpsypzws branch from bb3c116 to 16d1996 Compare June 15, 2026 17:03
@jcmuller jcmuller changed the title chore(ci): ensure nix package builds Update nix package and add CI step to ensure it always builds Jun 15, 2026

@0xjuanma 0xjuanma left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcmuller Sorry for the delay on this review, I've added a couple comments. Let me know your thoughts 👍🏽

Comment thread .github/workflows/nix.yml Outdated
permissions:
contents: read
env:
HAS_DEPLOY_KEY: ${{ secrets.SKILL_EVAL_DEPLOY_KEY != '' }}

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind explaining why this was added here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, apologies. I lifted this template from another project I maintain and we're also pushing up artifacts. Removed.

Comment thread .github/workflows/nix.yml Outdated
steps:
- uses: actions/checkout@v4
- uses: DeterminateSystems/nix-installer-action@v17
- uses: DeterminateSystems/magic-nix-cache-action@v8

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest release is v14, could we use that instead?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching. I've bumped all the steps to their latest versions.

@jcmuller
jcmuller force-pushed the jcmuller/push-xwukkpsypzws branch 2 times, most recently from a2fff55 to 45eff4c Compare July 24, 2026 18:56
@jcmuller
jcmuller force-pushed the jcmuller/push-xwukkpsypzws branch from 45eff4c to 3c7d776 Compare July 24, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants