Skip to content

Small improvements when object is renamed or created without asset #8741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ClementPasteau merged 1 commit into from
Jun 19, 2026
+12 −2
Merged

Small improvements when object is renamed or created without asset #8741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions newIDE/app/src/EditorFunctions/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,6 +962,7 @@ const createOrReplaceObject: EditorFunction = {
// the asset store, e.g. premade UI objects), use the tag as default
// search terms.
let effectiveSearchTerms = search_terms;
let assetSearchMissed = false;
let assetStoreTag: string | null = null;
if (candidateType && !effectiveSearchTerms && !asset_id) {
assetStoreTag = getAssetStoreTagForNewObject(candidateType);
Expand Down Expand Up @@ -1022,10 +1023,14 @@ const createOrReplaceObject: EditorFunction = {

if (createdObjects.length === 1) {
const object = createdObjects[0];
const renamedNotice =
object.getName() !== targetObjectName
? ` (requested name "${targetObjectName}" was taken; use "${object.getName()}" from now on)`
: '';
const result: EditorFunctionGenericOutput = {
success: true,
message: [
`Created object "${object.getName()}" (type "${object.getType()}", ${targetScopeText}) from asset store.`,
`Created object "${object.getName()}" (type "${object.getType()}", ${targetScopeText}) from asset store.${renamedNotice}`,
getPropertiesText(object),
].join(' '),
};
Expand Down Expand Up @@ -1061,6 +1066,7 @@ const createOrReplaceObject: EditorFunction = {
}

// No asset found - we'll create an object from scratch.
assetSearchMissed = true;
}
} catch (error) {
return makeGenericFailure(
Expand Down Expand Up @@ -1125,10 +1131,14 @@ const createOrReplaceObject: EditorFunction = {
isNewObjectTypeUsed: isTheFirstOfItsTypeInProject,
});

const scratchNotice = assetSearchMissed
? ` No asset matched "${effectiveSearchTerms ||
''}", so this object was created with no resource (no texture/3D model/font/etc...).`
: '';
const scratchResult: EditorFunctionGenericOutput = {
success: true,
message: [
`Created object "${targetObjectName}" (type "${candidateType}", ${targetScopeText}) from scratch.`,
`Created object "${targetObjectName}" (type "${candidateType}", ${targetScopeText}) from scratch.${scratchNotice}`,
getPropertiesText(object),
].join(' '),
};
Expand Down
Loading