[non-normative] Change default build settings#5020
Merged
leolzhao merged 5 commits intoJun 3, 2026
Conversation
leolzhao
approved these changes
Jun 1, 2026
Contributor
Author
|
There seem to be some CI failures. I'll check in a bit @leolzhao |
urvangjoshi
force-pushed
the
disable_simd_threads
branch
from
efb1d80 to
3daf433
Compare
Add asserts / checks to ensure certain conditions cannot occur
urvangjoshi
force-pushed
the
disable_simd_threads
branch
from
3daf433 to
6ac0340
Compare
Contributor
Author
|
A number of |
urvangjoshi
force-pushed
the
disable_simd_threads
branch
2 times, most recently
from
f0b813b to
63aca58
Compare
Also, - Remove multi-threaded tests from compilation - Ensure that encoder API doesn't allow specifying more than 1 thread.
This patch changes the default build settings to disable both multi-threading and SIMD on the normative branch, as requested by the AOMedia Codec Working Group.
urvangjoshi
force-pushed
the
disable_simd_threads
branch
from
63aca58 to
ae55ddd
Compare
Contributor
Author
|
@leolzhao : I have fixed the issues found by CI into separate commits. Pls review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes the default build settings to disable both multi-threading and SIMD on the normative branch, as requested by the AOMedia Codec Working Group.
Also, two pre-requisite changes:
#5023 #5022 #5025
Note: Needs to be merged without squashing to merge commits separately.