Fix run-to-run non-determinism in non-separable Wiener filter#5034
Merged
Conversation
Contributor
|
@jianle973 : pls review. |
urvangjoshi
force-pushed
the
mr/avm-bugfix
branch
from
60adbb5 to
2cd6ec2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix encoder run-to-run non-determinism caused by uninitialized memory in the non-separable Wiener filter restoration search path (av2/encoder/pickrst.c).
Multiple runs of the same encoding with identical inputs produce different chroma (U/V) results while luma (Y) is always identical. Reproduced with 4:2:2 12-bit content (SolLevanteFace) at QP 135, cpu-used=0, threads=2, described in issue #1500 , and r2r issue still occurs for some inter frame occasionally before this fix.