Skip to content

Cherry-pick C-only and multithread-off fixes from normative branch.#5038

Merged
urvangjoshi merged 1 commit into
AOMediaCodec:mainfrom
urvangjoshi:cp_conly_fixes
Jun 4, 2026
Merged

Cherry-pick C-only and multithread-off fixes from normative branch.#5038
urvangjoshi merged 1 commit into
AOMediaCodec:mainfrom
urvangjoshi:cp_conly_fixes

Conversation

@urvangjoshi
Copy link
Copy Markdown
Contributor

  • Static analyzer warning fixes in C-only build
  • Disable a multi-thread unit test when CONFIG_MULTITHREAD is off
  • When CONFIG_MULTITHREAD=0, force unit tests to use 1 thread
  • av2_update_states_c(): Avoid integer wrap-around
  • trellis_first_pos(): avoid integer wrap-around

Closes #5022 #5025

- Static analyzer warning fixes in C-only build
- Disable a multi-thread unit test when CONFIG_MULTITHREAD is off
- When CONFIG_MULTITHREAD=0, force unit tests to use 1 thread
- av2_update_states_c(): Avoid integer wrap-around
- trellis_first_pos(): avoid integer wrap-around
@urvangjoshi
Copy link
Copy Markdown
Contributor Author

@leolzhao @Krishna-Rapaka : This cherry-picks relevant parts (except build setting changes) from normative branc PRs #5020 and #5031

Pls review.

@Krishna-Rapaka
Copy link
Copy Markdown
Contributor

Thanks Urvang, looks good to me.

@urvangjoshi urvangjoshi enabled auto-merge (squash) June 4, 2026 19:33
@urvangjoshi urvangjoshi merged commit 000682c into AOMediaCodec:main Jun 4, 2026
109 checks passed
@urvangjoshi urvangjoshi deleted the cp_conly_fixes branch June 4, 2026 20:29
@Jamaika1
Copy link
Copy Markdown

Jamaika1 commented Jun 5, 2026

It worked and stopped working for CONFIG_MULTITHREAD 1 and HAVE_PTHREAD_H 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Encode/decode mismatch when built with -DCONFIG_MULTITHREAD=0

4 participants