feat(project): single approval grants full web access (no per-domain blocking)#227
Merged
Conversation
… blocking User pain: research/browse projects blocked on EVERY new domain (softr.io, techrepublic.com, ...), each needing a manual Grant — tedious and demo-hostile. Now one approval covers the whole plan's web access: - approve_plan(): if the plan browses (declares any network_domains OR uses a web/browse skill: web_search, web_fetch, chrome_*), grant network_domains=['*']. Path grants stay scoped (least privilege) — only network breadth widens, and only for plans that actually browse. - permission_gate(): '*' in network_domains authorizes any domain. Verified E2E on the live daemon: web research project drafted -> approved (granted ['*']) -> ran to COMPLETED with 0 domain blocks and produced its file. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ate test Broaden rather than replace: a browsing plan's grants keep their declared domains AND gain '*', so existing 'domain in grants' assertions hold and permission_gate still short-circuits on '*'. Updated test_e2e_full_lifecycle to assert both the '*' broad grant and the declared domains are present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Research/browse projects blocked on every new domain. Now approve_plan grants network_domains=[''] when the plan browses, and permission_gate honors ''. One approval = full web for the run. Path grants stay scoped. Verified E2E: web project ran to completed with 0 domain blocks.