fix(i18n): Improve Indonesian translation naturalness and fix missing entries#2190
fix(i18n): Improve Indonesian translation naturalness and fix missing entries#2190claycuy wants to merge 9 commits into
Conversation
Greptile SummaryThis PR improves the naturalness of the Indonesian (
Confidence Score: 5/5Safe to merge — translation-only changes with no logic impact and a valid JSON file. The change touches only the Indonesian locale file, the JSON is syntactically valid, and all previously flagged issues (missing comma, wrong key-binding terminology, spurious capitalisation, clipboard wording, garis/baris inconsistency) have been addressed. The specific fix requested by the reviewer — sentence-case "Tombol pintasan diperbarui" for "key bindings updated" — is confirmed correct at line 338. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[id-id.json translation file] --> B[Terminology fixes]
A --> C[Spelling corrections]
A --> D[Pronoun capitalisation]
A --> E[Missing translations filled]
B --> B1["binding kunci → tombol pintasan (5 entries)"]
B --> B2["garis → baris for line-related strings (2 entries)"]
B --> B3["clipboard → papan klip (2 entries)"]
C --> C1["kostum → kustom (8 entries)"]
C --> C2["Other word improvements (clear, restore, medium, etc.)"]
D --> D1["anda → Anda (3 entries)"]
E --> E1["clipboard not available translated"]
E --> E2["key bindings updated corrected"]
Reviews (4): Last reviewed commit: "fix(i18n): fix capitalisation for key bi..." | Re-trigger Greptile |
| "quicktools:curlybracket": "Masukkan kurung kurawal", | ||
| "quicktools:squarebracket": "Masukkan kurung persegi", | ||
| "quicktools:parentheses": "Masukkan tanda kurung", | ||
| "quicktools:parentheses": "Masukkan tAnda kurung", |
There was a problem hiding this comment.
A bulk find-and-replace of
anda → Anda (the Indonesian pronoun for "you") accidentally capitalised the A inside the unrelated words tanda (sign/symbol), beranda (home screen), and penanda (marker). Every affected entry now contains a mid-word capital letter (e.g. tAnda, berAnda, penAnda) that will look like a typo to Indonesian users. Twelve keys are affected across the file.
| "quicktools:parentheses": "Masukkan tAnda kurung", | |
| "quicktools:parentheses": "Masukkan tanda kurung", |
| "touch move threshold": "Ambang pergerakan sentuh", | ||
| "info-retryremotefsafterfail": "Ulangi koneksi FTP/SFTP ketika gagal.", | ||
| "info-fullscreen": "Sembunyikan Bilah Judul di Layar Beranda.", | ||
| "info-fullscreen": "Sembunyikan Bilah Judul di Layar BerAnda.", |
There was a problem hiding this comment.
Same spurious capitalisation:
BerAnda should be Beranda. This key's description is displayed in the settings panel so users will see the broken casing directly.
| "info-fullscreen": "Sembunyikan Bilah Judul di Layar BerAnda.", | |
| "info-fullscreen": "Sembunyikan Bilah Judul di Layar Beranda.", |
| "add to home screen": "Tambah ke layar berAnda", | ||
| "pin shortcuts not supported": "Pintasan layar berAnda tidak didukung di perangkat ini.", | ||
| "save file before home shortcut": "Simpan berkas sebelum menambahkannya ke layar berAnda.", |
There was a problem hiding this comment.
Three consecutive home-screen strings all have
berAnda instead of beranda. These are user-facing prompts shown when pinning shortcuts to the home screen.
| "add to home screen": "Tambah ke layar berAnda", | |
| "pin shortcuts not supported": "Pintasan layar berAnda tidak didukung di perangkat ini.", | |
| "save file before home shortcut": "Simpan berkas sebelum menambahkannya ke layar berAnda.", | |
| "add to home screen": "Tambah ke layar beranda", | |
| "pin shortcuts not supported": "Pintasan layar beranda tidak didukung di perangkat ini.", | |
| "save file before home shortcut": "Simpan berkas sebelum menambahkannya ke layar beranda.", |
| "quicktools:equal": "Masukkan simbol sama dengan", | ||
| "quicktools:slash": "Masukkan simbol slash", | ||
| "quicktools:exclamation": "Masukkan tanda seru", | ||
| "quicktools:exclamation": "Masukkan tAnda seru", |
There was a problem hiding this comment.
The same over-capitalisation affects several
quicktools:* entries (tAnda seru, tAnda gelombang, tAnda kutip terbalik, tAnda pagar, tAnda sisipan, tAnda hubung). All should use the lowercase tanda.
| "quicktools:exclamation": "Masukkan tAnda seru", | |
| "quicktools:exclamation": "Masukkan tanda seru", |
| "settings-info-editor-autosave": "Simpan perubahan secara otomatis setelah jeda.", | ||
| "settings-info-editor-color-preview": "Pratinjau nilai warna langsung di dalam editor.", | ||
| "settings-info-editor-fade-fold-widgets": "Redupkan penanda lipatan hingga dibutuhkan.", | ||
| "settings-info-editor-fade-fold-widgets": "Redupkan penAnda lipatan hingga dibutuhkan.", |
There was a problem hiding this comment.
Three
settings-info-editor-* entries have penAnda (marker) instead of penanda. These descriptions appear in the settings UI.
| "settings-info-editor-fade-fold-widgets": "Redupkan penAnda lipatan hingga dibutuhkan.", | |
| "settings-info-editor-fade-fold-widgets": "Redupkan penanda lipatan hingga dibutuhkan.", |
| "creating backup": "Membuat berkas cadangan", | ||
| "validating backup": "Memvalidasi cadangan", | ||
| "restoring key bindings": "Mengembalikan binding kunci", | ||
| "restoring key bindings": "Pulihkan binding kunci", |
There was a problem hiding this comment.
restoring key bindings uses the imperative form Pulihkan while every adjacent progress-indicator string uses the active verb form (Memulihkan plugin, Memulihkan pengaturan, Mengumpulkan, etc.). The inconsistent tense will read awkwardly during a restore operation.
| "restoring key bindings": "Pulihkan binding kunci", | |
| "restoring key bindings": "Memulihkan binding kunci", |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Okay, I have corrected your suggestion about the grammar.
There was a problem hiding this comment.
Then is there any other problem?
There was a problem hiding this comment.
There's one remaining inconsistency worth noting. The PR correctly translates "key bindings" to "Tombol pintasan" at line 110, but "restoring key bindings" at line 474 still uses the old term "binding kunci":
"restoring key bindings": "Memulihkan binding kunci",For consistency with the updated "key bindings" entry, this should be:
"restoring key bindings": "Memulihkan tombol pintasan",That's the only remaining issue I can see — everything else in the diff looks good.
Tip: You can customize Greptile's behavior for this repo with .greptile/rules.md and .greptile/config.json.
There was a problem hiding this comment.
I also see that there is the word "key binding" in a line other than line 474, are you sure that only line 474 needs to be changed?
There was a problem hiding this comment.
Good catch — you're right. Looking at the full file, "binding kunci" appears in several places that weren't updated in this PR:
| Key | Current value (post-PR) |
|---|---|
"key bindings updated" |
"Binding kunci diperbarui" |
"collecting key bindings" |
"Mengumpulkan binding kunci" |
"restoring key bindings" |
"Memulihkan binding kunci" ← line 474 |
"backup/restore note" |
"...dan binding kunci. Ini tidak..." |
"settings-info-app-keybindings" |
"Edit berkas binding kunci atau atur ulang pintasan." |
All five should be updated to use "tombol pintasan" to match the now-updated "key bindings": "Tombol pintasan" entry. I only called out line 474 previously because that was the specific diff context — but you're absolutely right that the other four entries need the same fix for consistency.
There was a problem hiding this comment.
I've fixed it, thank you. Are there any other spelling issues that aren't quite right?
There was a problem hiding this comment.
Looking at the full file, there are two remaining inconsistencies worth noting:
1. "clipboard" vs "papan klip"
These two entries use different words for "clipboard":
"copied to clipboard": "Disalin ke clipboard" ← English word
"clipboard not available": "Papan klip tidak tersedia." ← Indonesian
The first should be updated to match:
"copied to clipboard": "Disalin ke papan klip"2. "garis" vs "baris" for "line"
Most line-related entries consistently use "baris" (the standard Indonesian term for a text line):
"show line numbers"→"Tampilkan nomor baris""enter line number"→"Masukkan nomor baris""line height"→"Tinggi baris""line count"→"Jumlah baris"
But two entries stand out:
"relative line numbers": "Nomor garis relatif"
"line based rtl switching": "Beralih RTL berbasis garis"For consistency, both should use "baris":
"relative line numbers": "Nomor baris relatif"
"line based rtl switching": "Beralih RTL berbasis baris"Those are the only inconsistencies I can find — everything else looks good!
There was a problem hiding this comment.
I've fixed all your suggestions, but I just wanted to make sure everything is clear.
This comment has been minimized.
This comment has been minimized.
|
My bad, missed a comma earlier! Just pushed the fix and verified the JSON syntax. Ready for review again. 🙏 |
|
@greptile review again. |
|
@greptile I have fixed the capitalization typo for the 'key bindings updated' string to use sentence case in the latest commit. Could you please re-verify? |
|
@hyperz111 Kindly review it, when you're free. |
No description provided.