Skip to content

Fix well integrity parsing#125

Open
TheRealDougSchmidt wants to merge 3 commits into
AquaticInformatics:masterfrom
TheRealDougSchmidt:fix-well-integrity-parsing
Open

Fix well integrity parsing#125
TheRealDougSchmidt wants to merge 3 commits into
AquaticInformatics:masterfrom
TheRealDougSchmidt:fix-well-integrity-parsing

Conversation

@TheRealDougSchmidt

Copy link
Copy Markdown
Contributor

@ChrisKanaganayagam-AI @AlvinLee-AI I'm back from vacation, quickly cobbled up the remaining the WellIntegrity CSV and TOML example, and promptly found a bug!

This PR adds the example files and fixes the discovered bug.

I also noticed a couple of deployment quirks that someone at AquaticInformatics will need to fix, since I don't have project rights anymore.

Fix the published release version in the AppVeyor project

  • Change the AppVeyor project version to 25.4 and reset the next counter to 0

That should publish the next build of the plugin as v25.4.0 instead of v21.4.14, which aligns better with the expected plugin version naming patter. A plugin version of 25.4.x implies that the plugin will be compatible with AQTS 2025.4-or-higher.

Manually deploy the updated Blazor TestDrive project to GitHub pages

The previous version of the plugin from 4 years ago is still deployed at https://aquaticinformatics.github.io/tabular-field-data-plugin/test-drive/ so nobody can test the new functionality.

Someone with project admin rights will need to do this after the PR is merged:

  • Pull the latest master branch locally
  • Build the Solution in Release mode
  • Run docs/publish-test-drive.sh to publish the updated test drive project to GitHub Pages

Cheers!

Also added WellIntegrityPanel.razor to improve the display of well integrity activities
DelayedAppender was modified to merge WellIntegrity records from the same visit.

Unlike other DTOs, the WellIntegrity DTO is just a collection of other well-related activity, with no real defining properties.

The bug fix avoids 3 repair records on the same day creating 3 well integrity records with one repair each.

Now it will create a single well integrity record with 3 repair activities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant