Add oracle-round budget enforcement and liquidation distance safety for staged operations#339
Open
KillariDev wants to merge 1 commit into
Open
Add oracle-round budget enforcement and liquidation distance safety for staged operations#339KillariDev wants to merge 1 commit into
KillariDev wants to merge 1 commit into
Conversation
- Added oracle-round budget accounting, settlement/base-fee multipliers, and operation timeout/cap guards in `SecurityPoolOracleCoordinator` - Prevents expired auto-execute staging slots from blocking later valid oracle settlements and rejects operations when price is stale, overpriced, or budget-exceeded - Added liquidation threshold-distance checks and non-zero budget gating for staged liquidations and allowance/withdrawal ops - Propagated new oracle coordinator parameters through factory deployment and updated Create2 auction factory deployment path - Expanded Solidity and UI tests to cover new budget behavior, deferred execution semantics, and liquidation safety scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SecurityPoolOracleCoordinatorand factory deployments to cap oracle usage per price round, cap settlement base fee sensitivity, and define minimum liquidation distance from threshold.priceRoundMaxNotionalandpriceRoundConsumedNotional.isPriceFresh,getPriceRoundRemainingNotional,isPriceUsablehelpers and notional-based operation execution checks.ExecutedStagedOperationwith explicit reasons.Testing
solidity/ts/tests/priceOracleSecurity.test.tssolidity/ts/tests/peripherals.test.tsui/ts/tests/*for liquidation/security flow consistency and contract integration adjustmentsbun run tscbun run testbun run formatbun run checkbun run knip