Skip to content

Admin page mixin: move tabs padding from buttons to wrapper #48706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CGastrell merged 1 commit into from
May 12, 2026
+11 −9
Merged

Admin page mixin: move tabs padding from buttons to wrapper #48706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions projects/js-packages/base-styles/admin-page-layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,15 +301,13 @@ $jp-breakpoint-mobile: 782px;
background: var(--wpds-color-bg-surface-neutral-strong);
border-bottom: var(--wpds-border-width-xs) solid var(--wpds-color-stroke-surface-neutral-weak);

// Align tab buttons' inline padding with the page header's
// horizontal padding (admin-ui ships its page header at
// `padding-inline: var(--wpds-dimension-padding-2xl)`).
// `@wordpress/ui` Tabs default the buttons to `padding-inline:
// var(--wpds-dimension-padding-lg)`; bump them to 2xl so the
// first tab's start edge lines up under the page title.
[role="tab"] {
padding-inline: var(--wpds-dimension-padding-2xl, 24px);
}
// Align the first tab's start edge with the page header's title.
// admin-ui's page header sits at `padding-inline: 2xl` (24px); the
// `@wordpress/ui` tab buttons ship with their own `padding-inline:
// lg` (16px). Add the `sm` (8px) difference here on the wrapper so
// `lg + sm = 2xl` at the button's content edge — without touching
// the tab button's own padding.
padding-inline: var(--wpds-dimension-padding-sm, 8px);
}

// ── Mobile: admin bar grows to 46px; sidebar goes off-canvas ─────
Expand Down
4 changes: 4 additions & 0 deletions projects/js-packages/base-styles/changelog/update-admin-page-tabs-wrapper-padding
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Admin page mixin: move the tabs-strip horizontal padding from the tab buttons onto the `.jp-admin-page-tabs` wrapper, so we no longer override the @wordpress/ui tab button's own padding.
Loading