[WIP] Use local redistribute when possible even with mesh refinement. - #7090
Open
atmyers wants to merge 12 commits into
Open
[WIP] Use local redistribute when possible even with mesh refinement.#7090atmyers wants to merge 12 commits into
atmyers wants to merge 12 commits into
Conversation
for more information, see https://pre-commit.ci
atmyers
commented
Jul 21, 2026
Member
Author
|
Note, I am setting this to use my AMReX branch here for testing. Do not merge as is. |
atmyers
commented
Jul 24, 2026
| // is a physical upper bound on the number of cells crossed per direction. | ||
| amrex::RealVect max_distance_relative_to_grid; | ||
| for (int d = 0; d < AMREX_SPACEDIM; ++d) { | ||
| max_distance_relative_to_grid[d] = PhysConst::c * dt[0] / dx[d]; |
Member
Author
There was a problem hiding this comment.
The tests with sub-cycling still fail. Note that the above computes the number of cells moved on the coarse level, which is too small for particles in the fine patch. The safest thing to do is revert to the global Redistribute when sub-cycling is on.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supersedes #7044.