Enchancement: C and CPP support#102
Conversation
|
Reviewed — really nice work. The 7-test suite covering C/C++ corner cases (template prefix merging, namespace breadcrumbs, contained-text suppression) is particularly strong. Approved. The CI machinery was actually broken on
Once CI is green I'll merge. Thanks again @szavadsky. |
|
@runonthespot thanks, done. Thanks for the outstanding software |
|
Heads-up — main moved a lot today (0.7.5/0.7.6/0.7.7 cut + a 20-pack of dependabot bumps merged via #125). This PR has a Quickest fix: If easier, say the word and I'll open a follow-up PR from my fork that supersedes this one (giving you full credit). Otherwise happy to wait. |
|
@runonthespot I feel a follow-up PR by you will be easier for both. |
Ships #133 (security: 11 CodeQL alerts + 4 npm transitives closed) and #134 (clippy pedantic auto-fix cleanup across 27 files). After this release: open security alerts = 0 across both Dependabot and CodeQL surfaces. Cutting partly so the in-flight community PRs (#102 C/C++ support, #104 markdown support) have a clean current base to rebase on. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Quick update @szavadsky — we're cutting 0.7.10 right now (ships shortly), and after that we'll hold off merging any further changes to When you've got a moment, the rebase pattern is: I already verified locally that both branches resolve cleanly against current main with just a Cargo.lock regeneration. Once you push, CI will run fresh and I'll merge as soon as it's green. Thanks for the patience and the excellent work. |
|
@runonthespot done |
|
@runonthespot done, as far as I can tell CI/CD issues are just setup? |
|
Yup - hold tight
…On Sun, May 24, 2026 at 8:34 PM szavadsky ***@***.***> wrote:
*szavadsky* left a comment (BeaconBay/ck#102)
<#102 (comment)>
@runonthespot <https://github.com/runonthespot> done, as far as I can
tell CI/CD issues are just setup?
—
Reply to this email directly, view it on GitHub
<#102 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE263GSWTVPE5TTKGTPLDL44MQCLAVCNFSM6AAAAACZKSGV42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKMRZGM2TIMJTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Pushed two cleanup commits to your branch via maintainer-edits:
Verified locally: clippy clean at Pre-merge review notes (3 findings, none blocking)While CI re-runs, here are observations from a fresh deep review — all follow-up territory, none gate the merge:
Test-coverage gaps to consider (not for this PR)Header-only Once CI goes green I'll merge. Excellent work overall — the 9 tests are the strongest part and the namespace breadcrumb logic is well thought out. Will follow up #104 once it's rebased on current main. |
Mechanical pre-merge cleanup to get CI green:
- 6 collapsible_if patterns (cargo clippy --fix)
- rustfmt repositioning of the trailing { after the && chains
No logic changes.
Conflicts resolved: - CHANGELOG.md, README.md, docs-site language tables — kept both the C/C++ rows (from BeaconBay#102) and the Markdown row - ck-chunk/src/lib.rs — added template-prefix merge (Cpp) and small-chunk merge (Markdown) side by side; expanded the decorator-like trivia kinds match arm to include Markdown - Cargo.lock auto-resolved by cargo via the workspace deps Plus mechanical clippy --fix for 2 new warnings introduced by the merge interaction (needless_borrow + manual_range_contains).
Headline: C, C++, and Markdown language support land via #102 and #104 (both by @szavadsky). Plus the docs-deploy fix (#135) that resolves the vitepress build break caused by my unbounded vite override in 0.7.10. Also the live test of npm trusted publishing now that the repo's trusted-publisher config is verified saved on the npm side. See CHANGELOG.md. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
No description provided.