Skip to content

Add Shimmie2 site type (updated regex) - #3643

Open
GiovanH wants to merge 1 commit into
Bionus:developfrom
GiovanH:shimmie2
Open

Add Shimmie2 site type (updated regex)#3643
GiovanH wants to merge 1 commit into
Bionus:developfrom
GiovanH:shimmie2

Conversation

@GiovanH

@GiovanH GiovanH commented May 9, 2026

Copy link
Copy Markdown
Contributor

It's the same as Shimmie except it uses slightly different regular expressions.

@codecov

codecov Bot commented May 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.37500% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.03%. Comparing base (d5baa39) to head (f8c0fae).
⚠️ Report is 1042 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #3643       +/-   ##
============================================
+ Coverage    34.79%   46.03%   +11.23%     
============================================
  Files          404      486       +82     
  Lines        18464    29435    +10971     
  Branches         0     3827     +3827     
============================================
+ Hits          6425    13549     +7124     
- Misses       12039    15885     +3846     
- Partials         0        1        +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Bionus

Bionus commented May 16, 2026

Copy link
Copy Markdown
Owner

Is there a specific reason to have it as a separate source type? IIRC the current Shimmie source is already targeting Shimmie2 (all the sources under that type are using it).

@GiovanH

GiovanH commented May 16, 2026

Copy link
Copy Markdown
Contributor Author

The existing Shimmie source didn't seem to be compatible with any Shimmie2 instances so I assumed this would be a new type, but the regex changes could also be folded into the Shimmie source if you wanted.

@Bionus
Bionus force-pushed the develop branch 3 times, most recently from c71a861 to cf146fb Compare August 3, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants