Add RP9 package support by midwan · Pull Request #2186 · BlitterStudio/amiberry

midwan · 2026-07-17T13:58:49Z

Summary

add a namespace-aware RP9 manifest parser and hardened ZIP package extractor
apply RP9 machine, ROM, RAM, peripheral, video, clip, boot, and media settings without WHDBooter metadata
support RP9 from positional CLI arguments, --autoload, Quickstart, Play, drag-and-drop, Android, and libretro
handle embedded and external floppy, hard-disk, CD, tape, snapshot, shared-data, and boot media
register .rp9 and application/vnd.cloanto.rp9 across Linux/FreeBSD/Flatpak, macOS, iOS, Windows, and Android packages
add focused parser, Play detection, and cross-platform file-association tests

Why

RP9 packages contain both media and the complete machine configuration required to run them. Treating them like WHDLoad archives would incorrectly depend on WHDBooter JSON and lose the configuration encoded by the package.

The implementation follows the current RetroPlatform manifest, external-content, media-priority, shared-data, and SuperHires/interlaced clipping conventions. Archive extraction also rejects traversal, filesystem collisions, non-portable names, excessive entries, and oversized expansion.

Validation

parsed all 248 supplied Amiga Forever packages: 229 runnable packages accepted and 19 gallery/video-only packages rejected as non-emulation content, with no unexpected results
manually launched floppy, multidisk, embedded HDF, deploy HDF, CD32, and CDTV samples, including Asteroids, Gravitoids, Team 17 Development System, Nippon Safes, and Flight of the Amazon Queen
visually verified RP9 clipping with the full top-left content visible
macOS CMake build and generated bundle/codesign verification
Android testDebugUnitTest and ARM64 native build
full libretro build
tests/test_rp9_manifest.sh
tests/test_rp9_file_associations.sh
tests/test_play_content_detection.sh
tests/test_play_start_logic.sh
tests/test_play_use_content_logic.sh
git diff --check

References

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c0e08fe0b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Persist deployed media and reuse it on later launches. Reserve DF0 for ADF boot media and honor explicit A500/A2000 Kickstart versions.

midwan · 2026-07-17T14:38:52Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 070e8ddcef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Reset package-owned configuration and media when Quickstart ejects an RP9.

midwan · 2026-07-17T15:14:21Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1dbf61e03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

midwan · 2026-07-17T17:21:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f60d0d068

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Create an exclusive per-load directory before writing frontend-provided WHDLoad or RP9 data. Track and remove only artifacts owned by that load so name collisions cannot overwrite or delete existing save files.

midwan · 2026-07-17T17:48:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 41d2d681ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

midwan · 2026-07-17T20:29:35Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e2415881f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

midwan · 2026-07-17T20:56:07Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b060a6759

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-17T21:02:39Z

+	if (root == "absolute" || root == "external")
+		return path.is_absolute() && std::filesystem::exists(path, error) ? path : std::filesystem::path {};


Reject package-supplied absolute host paths

When an untrusted RP9 declares an absolute or external hard-drive path such as <harddrive root="absolute">/home/user</harddrive>, this branch accepts any existing host directory; add_harddrive() then mounts it read-write because readonly defaults to false. Guest code included in the same package can consequently modify or delete arbitrary user files, so external roots should require explicit user approval or be rejected/read-only.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-17T21:02:39Z

+			} else {
+				write_log(_T("RP9: additional CD available in extracted package: %s\n"), path_string.c_str());


Keep additional packaged CDs available for swapping

When an RP9 contains multiple <cd> entries, only the first is attached; every later image is merely logged and is not retained in another slot, the CD MRU list, or another swap structure. Multi-disc packages therefore have no usable path to select disc 2 from the package during emulation, unlike extra floppies which are preserved in dfxlist.

Useful? React with 👍 / 👎.

Reject package-controlled external host paths to prevent untrusted media from mounting writable user directories. Publish packaged CDs only after successful validation, preserving their priority order for swapping.

feat(rp9): add package support

1c0e08f

midwan marked this pull request as ready for review July 17, 2026 14:00

midwan self-assigned this Jul 17, 2026

chatgpt-codex-connector Bot reviewed Jul 17, 2026

View reviewed changes

Comment thread src/osdep/amiberry_rp9.cpp

Comment thread src/osdep/amiberry_rp9.cpp Outdated

Comment thread src/osdep/amiberry_rp9.cpp Outdated

fix(rp9): correct package launch state

070e8dd

Persist deployed media and reuse it on later launches. Reserve DF0 for ADF boot media and honor explicit A500/A2000 Kickstart versions.

chatgpt-codex-connector Bot reviewed Jul 17, 2026

View reviewed changes

Comment thread src/osdep/amiberry_rp9.cpp Outdated

Comment thread src/osdep/amiberry_rp9.cpp

Comment thread src/osdep/imgui/quickstart.cpp Outdated

fix(rp9): honor media priority and lifetime

a1dbf61

Reset package-owned configuration and media when Quickstart ejects an RP9.

chatgpt-codex-connector Bot reviewed Jul 17, 2026

View reviewed changes

Comment thread src/osdep/amiberry_rp9.cpp Outdated

fix(rp9): make package loading transactional

6f60d0d

chatgpt-codex-connector Bot reviewed Jul 17, 2026

View reviewed changes

Comment thread libretro/libretro.cpp Outdated

fix(libretro): isolate staged content

41d2d68

Create an exclusive per-load directory before writing frontend-provided WHDLoad or RP9 data. Track and remove only artifacts owned by that load so name collisions cannot overwrite or delete existing save files.

chatgpt-codex-connector Bot reviewed Jul 17, 2026

View reviewed changes

Comment thread src/osdep/amiberry_rp9.cpp Outdated

Comment thread src/osdep/amiberry.cpp

Comment thread src/osdep/imgui/quickstart.cpp

fix(rp9): honor package configuration

5e24158

chatgpt-codex-connector Bot reviewed Jul 17, 2026

View reviewed changes

Comment thread src/cfgfile.cpp Outdated

Comment thread src/osdep/amiberry_rp9.cpp

fix(rp9): isolate ROM and restore state

9b060a6

chatgpt-codex-connector Bot reviewed Jul 17, 2026

View reviewed changes

fix(rp9): secure paths and CD swaps

303ab87

Reject package-controlled external host paths to prevent untrusted media from mounting writable user directories. Publish packaged CDs only after successful validation, preserving their priority order for swapping.

		if (root == "absolute" \|\| root == "external")
		return path.is_absolute() && std::filesystem::exists(path, error) ? path : std::filesystem::path {};

		} else {
		write_log(_T("RP9: additional CD available in extracted package: %s\n"), path_string.c_str());

Uh oh!

Uh oh!

Conversation

midwan commented Jul 17, 2026

Summary

Why

Validation

References

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

midwan commented Jul 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

midwan commented Jul 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

midwan commented Jul 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

midwan commented Jul 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

midwan commented Jul 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

midwan commented Jul 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant