Skip to content

refactor: remove lsp and vscode#326

Merged
KyrylR merged 2 commits into
BlockstreamResearch:masterfrom
stringhandler:refactor/move-lsp
May 20, 2026
Merged

refactor: remove lsp and vscode#326
KyrylR merged 2 commits into
BlockstreamResearch:masterfrom
stringhandler:refactor/move-lsp

Conversation

@stringhandler
Copy link
Copy Markdown
Contributor

Removes the LSP and VS Code extension from this repo and into https://github.com/BlockstreamResearch/simplicityhl-lsp

Motivation

When trying to update rust-simplicity in #314 I am unable to get the full project to pass CI. This is because the LSP project references Simplicity via a crates version.

As it stands, there are usually multiple PRs to update the LSP after code in the rest of the project is edited.

@stringhandler stringhandler requested a review from delta1 as a code owner May 19, 2026 13:34
@ivanlele
Copy link
Copy Markdown

On the CI side, for #314, I think we can make it pass without touching the LSP. From what I’ve seen, it’s a standalone crate and pulls simplicityhl from crates.io. It also seems to even use an older version: simplicityhl = "0.5.0-rc.0" (in the master we already have 0.6.0).

Some time ago, I created a commit with the new rust-simplicity version so I could continue working on a my feature. The CI passes without changing anything besides src and main manifest files, I hope it might help:
ivanlele@76f7d18

@KyrylR
Copy link
Copy Markdown
Collaborator

KyrylR commented May 20, 2026

Make sense, though it would be nice to have to separate repos one for lsp another for vscode (to avoid ambiguity)

@stringhandler
Copy link
Copy Markdown
Contributor Author

Yeah even better

@gerau
Copy link
Copy Markdown
Contributor

gerau commented May 20, 2026

I moved the vscode extension to its own repo: https://github.com/BlockstreamResearch/simplicityhl-vscode

@KyrylR
Copy link
Copy Markdown
Collaborator

KyrylR commented May 20, 2026

@gerau should we proceed with removal?

@gerau
Copy link
Copy Markdown
Contributor

gerau commented May 20, 2026

Yes, we can.

Copy link
Copy Markdown
Collaborator

@KyrylR KyrylR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c3f0ce8; successfully ran local tests, docs and review

@KyrylR KyrylR merged commit 88b6226 into BlockstreamResearch:master May 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants