ci: type-check with all extras installed#97
Merged
Conversation
Close the pyright blind spot where optional provider imports were never checked against real stubs. Fix Azure/Google embeddings typing revealed by the fuller install. Fixes #96.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the CI Typecheck (pyright) job install optional extras (
uv sync --frozen --all-extras), matching pytest, so provider-specific code is type-checked against real stubs. Fixes the twocore/embeddings.pyerrors that only appear with extras installed (AzureSecretStr, Googlegoogle_api_keypydantic/__init__stub artifact).Fixes #96
Checklist
make testpasses locally).make check, i.e.ruff check .+ruff format --check .).docs/,.env.example,CHANGELOG.md).Test plan
uv sync --frozen --all-extras && uv run pyright→ 0 errors locallyuv run pytestgreen; ruff check + format check clean--all-extrasand passes on this PRCONTRIBUTING.mddocuments the local reproduction commands