Updated and filled the footer to width - #117
Open
ameynaik-9 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for cops ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
IamEzio
requested changes
Oct 7, 2022
IamEzio
left a comment
Member
There was a problem hiding this comment.
Thanks @ameynaik-9. However, I have some concerns:
- The navbar is broken in mobile view. Align it properly and try to make the ordering of the content similar to the current one. Ref:

- On hover, don't change the text color to red, instead scale them as they are done in the navbar to maintain consistency.
- Make sure the footer stays at the bottom of the page even if the rest of the content doesn't span to full page height. Refer to the team page of the deply preview:

Member
|
@ameynaik-9 updates on this? |
Member
Author
|
I'll surely look into it bhaiya just undergoing overloads midsem.
…On Tue, 13 Dec 2022, 00:01 Lakshya Singh, ***@***.***> wrote:
@ameynaik-9 <https://github.com/ameynaik-9> updates on this?
—
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AY5E6I5WLTHN2VCRT2F2ZZ3WM5VOLANCNFSM6AAAAAAQ7BN2EE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ans- The footer was just in centre and was not sized perfectly so I have made it fixed to width
Fixes
Fixes #[issue number] by @[issue author]
Types of changes
Checklist: