Skip to content

Separating cross-contour notebook#690

Open
wghuneke wants to merge 8 commits into
COSIMA:mainfrom
wghuneke:main
Open

Separating cross-contour notebook#690
wghuneke wants to merge 8 commits into
COSIMA:mainfrom
wghuneke:main

Conversation

@wghuneke

@wghuneke wghuneke commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Notebook is cleaned up, code that extracts the contour is moved to a new notebook.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@adele-morrison
adele-morrison self-requested a review July 2, 2026 04:05
@adele-morrison

Copy link
Copy Markdown
Collaborator

I did a bunch of edits on Approach 2 in Create_contour.ipynb.

Based on decisions today at the hackathon, we still need to remove the creation of transport masks for Approach 1 in Create_contour.ipynb and just simplify to produce a mask to e.g. plot temperature on the shelf. When we do that, we can also close #383, because it will no longer be relevant.

@claireyung claireyung mentioned this pull request Jul 8, 2026
3 tasks
@wghuneke

Copy link
Copy Markdown
Collaborator Author

I have now cleaned up Approach 1 and removed code that calculates the transport masks.

I have also checked the saved files we reference at the beginning. I did this by loading the masks and inspecting contour_masked_above. If that shows diagonal connections, I interpreted that as being produced using Approach 1. Does this sound reasonable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants