[mount] manual partitioning & btrfs setup#166
Open
beyondbrokkoli wants to merge 175 commits intoCachyOS:cachyos-devfrom
Open
[mount] manual partitioning & btrfs setup#166beyondbrokkoli wants to merge 175 commits intoCachyOS:cachyos-devfrom
beyondbrokkoli wants to merge 175 commits intoCachyOS:cachyos-devfrom
Conversation
benefit: the btrfs umount is not happening in the same loop as the --bind chroot mounts. separating btrfsSubvolumes from extraMounts for "good measure". other relevant changes: sorting mountpoints by number of "/". the rest of the changes are irrelevant "auto" refactoring.
revert back to lexical sorting
exclude subvolumes that would be nested on another partition causing umount errors
pacman permission error workaround
breaking everything
now that everything is separated we can do the lazy umount -l without risking hitting sensitive bind mounts. the calamares parent process holds the directory so a regular umount doesn't work
"magic tricks"
option is already present
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conflicts
Error Message
The device '/dev/sda4' is mounted in the target system. It is mounted at '/tmp/calamares-root-20bdpvzd/var/tmp'. The device could not be unmounted.How To Reproduce
Setting a different partition for /var clashes with the settings in mount.conf
Extended filtering avoids this issue
I suggest using a different directory for btrfs subvolume creation and blocking ntfs, ext2 and fat16
Only allowing fat32 on /boot /boot/efi
All partitions except for /home /srv /boot /boot/efi should be empty to avoid conflicts post-install
Isolated subvolume creation via temporary directories completely avoids unmounting the main calamares-root
The mounting logic is now phased to ensure physical disks are always ready before chroot binds
Defensive checks now prevent cluttered installs and the error function handles stray mounts
btrfs swap-to-file functionality remains untested due to current configuration constraints
Tested with 260124 ISO
evidence
successfull install
try it out
https://github.com/beyondbrokkoli/cachyos-calamares/blob/patch-1/src/modules/mount/main.py
sudo rm /usr/lib/calamares/modules/mount/main.pysudo nano /usr/lib/calamares/modules/mount/main.pycopy + pastesudo calamares -dsummary