-
Notifications
You must be signed in to change notification settings - Fork 62
media: cx231xx: Fix Elgato Video Capture V2 default norm for PAL regions #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| ``` | ||
| --- a/drivers/media/usb/cx231xx/cx231xx-cards.c | ||
| +++ b/drivers/media/usb/cx231xx/cx231xx-cards.c | ||
| @@ -637,7 +637,7 @@ | ||
| .ctl_pin_status_mask = 0xFFFFFFC4, | ||
| .agc_analog_digital_select_gpio = 0x0c, | ||
| .gpio_pin_status_mask = 0x4001000, | ||
| - .norm = V4L2_STD_NTSC, | ||
| + .norm = V4L2_STD_PAL, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about V4L2_STD_ALL? I worry this change regresses people that are using NTSC. edit: I think
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the feedback! I tested both V4L2_STD_NTSC | V4L2_STD_PAL (0x00000fff) and V4L2_STD_ALL (0xffffffff) via v4l2-ctl at runtime but both still produce a scrambled image. The issue is that the cx25840 decoder chip ignores runtime standard changes on this device — the norm must be set correctly in the driver card definition for the hardware to initialize properly at firmware load time. Changing to V4L2_STD_PAL in the card definition is the only fix that works. I'm based in Norway so PAL is correct for my region. Happy to test any other suggestions!
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you report this to kernel bugzilla? I don' think I can accept this change due to aforementioned regression. |
||
| .no_alt_vanc = 1, | ||
| .external_av = 1, | ||
| .input = {{ | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove backtick