fix: gracefully handle pipeline init errors due to corrupted SQLite cache#832
Open
octo-patch wants to merge 1 commit intoCinnamon:mainfrom
Open
fix: gracefully handle pipeline init errors due to corrupted SQLite cache#832octo-patch wants to merge 1 commit intoCinnamon:mainfrom
octo-patch wants to merge 1 commit intoCinnamon:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #744
Problem
After running kotaemon for an extended period (e.g., in a tmux session), the
diskcache/SQLite cache used bytheflowcan become unavailable or corrupted. This causessqlite3.OperationalError: no such table: Cacheto propagate unhandled whenSuggestConvNamePipelineorSuggestFollowupQuesPipelineare initialized, crashing the chat callback and surfacing as an error to the user on every action.Solution
Wrap the pipeline initialization calls in
check_and_suggest_name_convandsuggest_chat_convwithtry/exceptblocks. When initialization fails, a warning is logged and the functions return a graceful no-op result instead of propagating the error. The naming and follow-up suggestion features are non-critical — the chat still works correctly without them.Testing
gr.update(), Falsefromcheck_and_suggest_name_convwithout crashing when pipeline init raises an exception.