Summarize files added and overwritten after adds - #21
Merged
Conversation
Show an info dialog after add-to-archive operations (single add, folder add, archive merge, and drag-drop) reporting how many files were new versus overwritten. The overwritten file names are listed under the dialog Show Details button so a silent Overwrite default no longer hides what was replaced.
triatomic
force-pushed
the
feature/overwrite-summary
branch
from
May 29, 2026 09:46
3ca06c9 to
2709472
Compare
Owner
|
This doesn't seem to work correctly, with some behaviours, like dragging between archives, files are falsely reported as new. Similar problem when drag-dropping multiple files from a folder and then doing Yes All |
Contributor
Author
this was intended for the silent behavior (overwrite) |
Owner
|
Why can't the feature work consistently across all behaviours as described in _classify_add? Feature should consistently identify if a file wasn't added, replaced an existing file or created a new entry. |
Overwrites under skip_all (drag between archives, Yes-to-All) were miscounted as new because the classifier read the dialog button, which is absent when no prompt shows. Return an explicit AddOutcome instead.
QMessageBox can't be resized, so the file list was cramped. Replace it with AddSummaryDialog: resizable, maximizable, with a Show/Hide Details toggle listing new files then a separator then overwritten files.
The drop handler tallied each file under its dropped name, but smart-replace or the rename prompt may store it under another. Return the resolved name from _add_resolved so the summary lists the real entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After add-to-archive operations, show an information dialog summarizing how many files were added — split into new vs overwritten.
Previously, when the Add Overwrite Default is set to Overwrite, existing files were replaced silently; the only feedback was the
*modified-marker in the title bar. This adds explicit confirmation.Where it fires
_add_file/_add_file_with_name)_add_folder)merge_archives— one combined summary across all source archives)The disk-extract flow (
extract/extract_all/extract_filtered) is intentionally left as-is — it delegates to thepyBIGlibrary and does not surface per-file overwrite info.Details
The dialog shows e.g.
Added 2019 file(s) — 2016 new, 3 overwritten.When any files were overwritten, their names are listed under the dialog's Show Details... button, so long lists stay collapsed by default.Notes