Add FiberScheduler::connect and FiberScheduler::accept#52
Merged
Conversation
vadimskipin
reviewed
May 29, 2026
vadimskipin
left a comment
vadimskipin
left a comment
Collaborator
There was a problem hiding this comment.
Would be great to have both connect/accept supported.
mstetsyuk
changed the title
FiberScheduler::connectFiberScheduler::connect and FiberScheduler::accept
Collaborator
|
please use |
keep SOCK_NONBLOCK accept and tests bb fmt
mstetsyuk
marked this pull request as ready for review
May 29, 2026 17:30
vadimskipin
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
io_uringsupportsconnectandaccept, so we can addFiberScheduler::connectandFiberScheduler::acceptto avoid configuring non-blocking sockets and callingFiberScheduler::pollas it's more code and extra syscalls