Skip to content

App Meal Nutrition + UI Tweaks#1194

Merged
CodeWithCJ merged 10 commits intoCodeWithCJ:mainfrom
apedley:app-ui-updates
Apr 25, 2026
Merged

App Meal Nutrition + UI Tweaks#1194
CodeWithCJ merged 10 commits intoCodeWithCJ:mainfrom
apedley:app-ui-updates

Conversation

@apedley
Copy link
Copy Markdown
Contributor

@apedley apedley commented Apr 23, 2026

Tip

Help us review and merge your PR faster!
Please ensure you have completed the Checklist below.
For Frontend changes, please run pnpm run validate to check for any errors.
PRs that include tests and clear screenshots are highly preferred!
Note: AI-generated descriptions must be manually edited for conciseness. Do not paste raw AI summaries.

Description

This PR contains multiple small UI bug fixes and a new screen to show meal nutrient breakdown. The new screen is reachable by tapping the name of a meal in the diary screen. Misc fixes:

  1. fixed keyboard not avoiding view when input was in a bottom sheet
  2. fixed missing prev and next day buttons from diary screen
  3. added swipe to delete on exercise in diary to match food
  4. moved the more advanced nutrients (vitamins, potassium) under a toggle in the food view screens so the entire screen isn't taken up by nutrition
  5. long food names now wrap serving size to the next line but shorter names stay on one
  6. added rings to active form inputs
  7. fixed onboarding screen keyboard covering inputs

Linked Issue: #

How to Test

  1. Check out this branch and run ...
  2. Navigate to...
  3. Verify that...

PR Type

  • Issue (bug fix)
  • New Feature
  • Refactor
  • Documentation

Checklist

All PRs:

  • [MANDATORY - ALL] Integrity & License: I certify this is my own work, free of malicious code, and I agree to the License terms.

New features only:

  • [MANDATORY for new feature] Alignment: I have raised a GitHub issue and it was reviewed/approved by maintainers or it was approved on Discord.

Frontend changes (SparkyFitnessFrontend/ or src/):

  • [MANDATORY for Frontend changes] Quality: I have run pnpm run validate and it passes.
  • [MANDATORY for Frontend changes] Translations: I have only updated the English (en) translation file.

Backend changes (SparkyFitnessServer/):

  • [MANDATORY for Backend changes] Code Quality: I have run typecheck, lint, and tests. New files use TypeScript, new endpoints have Zod schemas, and new endpoints include tests.
  • [MANDATORY for Backend changes] Database Security: I have updated rls_policies.sql for any new user-specific tables.

UI changes (components, screens, pages):

  • [MANDATORY for UI changes] Screenshots: I have attached Before/After screenshots below.

Screenshots

Click to expand

Before

before

After

after

Notes for Reviewers

Optional — use this for anything that doesn't fit above: known tradeoffs, areas you'd like specific feedback on, qustions you have or context that helps reviewers.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new MealNutrition screen and associated utilities to provide detailed nutritional breakdowns for logged meals. It also enhances the UI by adding focus states to inputs, implementing swipe-to-delete for exercises via a new SwipeableExerciseRow component, and adding a toggle for additional nutrients in food summaries. Feedback focuses on correcting the use of the never type in StepperInput event handlers, improving type safety for refs in SwipeableExerciseRow, and addressing accessibility and contrast concerns for the delete action.

Comment thread SparkyFitnessMobile/src/components/StepperInput.tsx Outdated
Comment thread SparkyFitnessMobile/src/components/SwipeableExerciseRow.tsx Outdated
Comment thread SparkyFitnessMobile/src/components/SwipeableExerciseRow.tsx
@CodeWithCJ
Copy link
Copy Markdown
Owner

hi @apedley please check conflict on SparkyFitnessMobile/src/components/FoodNutritionSummary.tsx

@apedley
Copy link
Copy Markdown
Contributor Author

apedley commented Apr 25, 2026

hi @apedley please check conflict on SparkyFitnessMobile/src/components/FoodNutritionSummary.tsx

should be good now

@CodeWithCJ CodeWithCJ merged commit 71f277b into CodeWithCJ:main Apr 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants