Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces Android widget support using Jetpack Glance. It includes new Expo config plugins to configure the Android build environment (Compose support, dependencies) and register the calorie widget. The useWidgetSync hook is updated to push calorie data to the Android widget via a new native bridge. Feedback suggests optimizing the synchronization logic to prevent excessive bridge calls, improving the robustness of the plugin's regex-based code injection, and dynamically handling the Kotlin version in the build configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tip
Help us review and merge your PR faster!
Please ensure you have completed the Checklist below.
For Frontend changes, please run
pnpm run validateto check for any errors.PRs that include tests and clear screenshots are highly preferred!
Note: AI-generated descriptions must be manually edited for conciseness. Do not paste raw AI summaries.
Description
This PR adds an android widget for calorie tracking. I am not ashamed to say this was a struggle so Android gets one widget for now. At least now I can say I know a little Kotlin.
Androids widget system is a lot less flexible than iOS and I couldn't make the calorie ring function well on all the launchers so the widget is a bit simplified.
Linked Issue: #
How to Test
PR Type
Checklist
All PRs:
New features only:
Frontend changes (
SparkyFitnessFrontend/orsrc/):pnpm run validateand it passes.en) translation file.Backend changes (
SparkyFitnessServer/):rls_policies.sqlfor any new user-specific tables.UI changes (components, screens, pages):
Screenshots
Notes for Reviewers