Add ITDA to custom-node-list#3090
Open
designloves2 wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe custom node registry now includes an ChangesITDA Registry
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I would like to add my custom node ITDA to the list.
Repository: https://github.com/designloves2/itda
ITDA is a frame-accurate, layered video editor that runs inside ComfyUI, built for the workflow where you generate video clips with AI and then have to join them into one continuous piece. Its main feature, Auto Stitch, analyses the overlap between two clips and recommends where to cut, scoring candidates on frame similarity and optical-flow motion continuity.
Nodes:
ITDA Open Editor(opens the editor in-graph, outputs the project name),ITDA Load Export(loads the latest export as an IMAGE batch + AUDIO).Path handling
Aware of the containment requirements from previous reviews, I audited every path surface before submitting — write side, read side, and paths that arrive as data rather than as request arguments:
folder_pathsdirectories (input/ITDA,input/ITDA-SNAPSHOT,output/ITDA); nothing is written inside the package.is_contained()helper that resolves the path first (collapsing..and symlinks) and then checks real parentage viaPath.parents— never a string prefix, so/a/bcis not treated as inside/a/b. There are nostartswith()-based path checks anywhere../..), which otherwise survive separator stripping and collapse a per-project directory one level up.shell=True), and values interpolated into filter strings are type-cast or pattern-validated.ffmpeg work also runs off the event loop, so a long export does not block the ComfyUI server.
Requires ffmpeg on PATH. OpenCV and librosa are optional and only enable extra analysis features; both degrade gracefully when absent.
Thank you for reviewing!