-
Notifications
You must be signed in to change notification settings - Fork 86
Add options flyout #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vgromfeld
wants to merge
2
commits into
CommunityToolkit:main
Choose a base branch
from
vgromfeld:addOptionsFlyout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+107
−1
Open
Add options flyout #804
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -19,6 +19,8 @@ namespace CommunityToolkit.WinUI.Controls; | |||||
| [TemplateVisualState(GroupName = ScrollButtonGroupNameTemplatePart, Name = DecrementButtonStateTemplatePart)] | ||||||
| [TemplateVisualState(GroupName = ScrollButtonGroupNameTemplatePart, Name = IncrementButtonStateTemplatePart)] | ||||||
| [TemplateVisualState(GroupName = ScrollButtonGroupNameTemplatePart, Name = BothButtonsStateTemplatePart)] | ||||||
| [TemplateVisualState(GroupName = OptionsGroupNameTemplatePart, Name = OptionsVisibleStateTemplatePart)] | ||||||
| [TemplateVisualState(GroupName = OptionsGroupNameTemplatePart, Name = OptionsCollapsedStateTemplatePart)] | ||||||
| public sealed partial class Ribbon : Control | ||||||
| { | ||||||
| private const string PanelTemplatePart = "Panel"; | ||||||
|
|
@@ -30,6 +32,9 @@ public sealed partial class Ribbon : Control | |||||
| private const string DecrementButtonStateTemplatePart = "DecrementButton"; | ||||||
| private const string IncrementButtonStateTemplatePart = "IncrementButton"; | ||||||
| private const string BothButtonsStateTemplatePart = "BothButtons"; | ||||||
| private const string OptionsGroupNameTemplatePart = "OptionsGroup"; | ||||||
| private const string OptionsVisibleStateTemplatePart = "OptionsVisible"; | ||||||
| private const string OptionsCollapsedStateTemplatePart = "OptionsCollapsed"; | ||||||
|
|
||||||
| private Panel? _panel; | ||||||
| private ScrollViewer? _scrollViewer; | ||||||
|
|
@@ -55,6 +60,60 @@ public double ScrollStep | |||||
| set => SetValue(ScrollStepProperty, value); | ||||||
| } | ||||||
|
|
||||||
| /// <summary> | ||||||
| /// The DP to store the <see cref="OptionsFlyout"/> property value. | ||||||
| /// </summary> | ||||||
| public static readonly DependencyProperty OptionsFlyoutProperty = DependencyProperty.Register( | ||||||
| nameof(OptionsFlyout), | ||||||
| typeof(FlyoutBase), | ||||||
| typeof(Ribbon), | ||||||
| new PropertyMetadata(null, OnOptionsFlyoutPropertyChanged)); | ||||||
|
|
||||||
| /// <summary> | ||||||
| /// The flyout to display when the user clicks on the ribbon options button. | ||||||
| /// </summary> | ||||||
| public FlyoutBase? OptionsFlyout | ||||||
| { | ||||||
| get => (FlyoutBase?)GetValue(OptionsFlyoutProperty); | ||||||
| set => SetValue(OptionsFlyoutProperty, value); | ||||||
| } | ||||||
|
|
||||||
| /// <summary> | ||||||
| /// The DP to store the <see cref="OptionsAccessibleName"/> property value. | ||||||
| /// </summary> | ||||||
| public static readonly DependencyProperty OptionsAccessibleNameProperty = DependencyProperty.Register( | ||||||
| nameof(OptionsAccessibleName), | ||||||
| typeof(string), | ||||||
| typeof(Ribbon), | ||||||
| new PropertyMetadata(string.Empty)); | ||||||
|
|
||||||
| /// <summary> | ||||||
| /// The accessible name for the options button. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
This is the standard comment pattern for a property |
||||||
| /// </summary> | ||||||
| public string OptionsAccessibleName | ||||||
| { | ||||||
| get => (string)GetValue(OptionsAccessibleNameProperty); | ||||||
| set => SetValue(OptionsAccessibleNameProperty, value); | ||||||
| } | ||||||
|
|
||||||
| /// <summary> | ||||||
| /// The DP to store the <see cref="OptionsAccessKey"/> property value. | ||||||
| /// </summary> | ||||||
| public static readonly DependencyProperty OptionsAccessKeyProperty = DependencyProperty.Register( | ||||||
| nameof(OptionsAccessKey), | ||||||
| typeof(string), | ||||||
| typeof(Ribbon), | ||||||
| new PropertyMetadata(string.Empty)); | ||||||
|
|
||||||
| /// <summary> | ||||||
| /// The access key to set on the options flyout button. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| /// </summary> | ||||||
| public string OptionsAccessKey | ||||||
| { | ||||||
| get => (string)GetValue(OptionsAccessKeyProperty); | ||||||
| set => SetValue(OptionsAccessKeyProperty, value); | ||||||
| } | ||||||
|
|
||||||
| public Ribbon() | ||||||
| { | ||||||
| DefaultStyleKey = typeof(Ribbon); | ||||||
|
|
@@ -97,6 +156,8 @@ protected override void OnApplyTemplate() | |||||
| _scrollViewer.SizeChanged += OnSizeChanged; | ||||||
| UpdateScrollButtonsState(); | ||||||
| } | ||||||
|
|
||||||
| UpdateOptionsFlyoutState(); | ||||||
| } | ||||||
|
|
||||||
| private void OnItemsCollectionChanged(object? sender, NotifyCollectionChangedEventArgs e) | ||||||
|
|
@@ -198,4 +259,15 @@ private void OnDecrementScrollViewer(object sender, RoutedEventArgs e) | |||||
|
|
||||||
| private void OnIncrementScrollViewer(object sender, RoutedEventArgs e) | ||||||
| => _scrollViewer?.ChangeView(_scrollViewer.HorizontalOffset + ScrollStep, verticalOffset: null, zoomFactor: null); | ||||||
|
|
||||||
| private static void OnOptionsFlyoutPropertyChanged(DependencyObject d, DependencyPropertyChangedEventArgs e) | ||||||
| { | ||||||
| var ribbon = (Ribbon)d; | ||||||
| ribbon.UpdateOptionsFlyoutState(); | ||||||
| } | ||||||
|
|
||||||
| private void UpdateOptionsFlyoutState() => VisualStateManager.GoToState( | ||||||
| this, | ||||||
| OptionsFlyout != null ? OptionsVisibleStateTemplatePart : OptionsCollapsedStateTemplatePart, | ||||||
| useTransitions: true); | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.