fix: bug fixes, performance improvements and code cleanup (#17)#17
Merged
fix: bug fixes, performance improvements and code cleanup (#17)#17
Conversation
Fixes: - Disks sheet: use disk's own storage for lookup instead of VM primary storage - Nodes Networks sheet: Node column was always null, now shows per-row node - SSL certificate: DaysUntilExpiry no longer crashes when NotAfter is zero - Replication sheet: Summary count now reports rows written not node count - Cluster sheet: TFA table was making a duplicate API call - Firewall: state variables are now local, safe for multiple GenerateAsync calls Performance: - Firewall: cluster and per-guest calls parallelized with Task.WhenAll - Replication: all nodes fetched in parallel - StorageContent: written in a single parallel pass with CreateTable - RRD: TimeFrame/Consolidation evaluated once before the parallel loop Code quality: - Firewall: removed 4 class fields and 3 private methods, replaced with local functions - ProgressTracker: Interlocked.Increment + Volatile.Write for thread safety - Single-table sheets: removed redundant table title (null)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
ReportEngineinstance without crash