fix: declare apache-arrow as a direct runtime dependency#194
Merged
rwmjhb merged 1 commit intoCortexReach:masterfrom Mar 14, 2026
Merged
Conversation
05ca963 to
c3b553c
Compare
c3b553c to
1a3e0a4
Compare
Collaborator
|
感谢这个聚焦修复。 我这边复现了 本地已在隔离目录上应用 PR 补丁并跑完整 |
rwmjhb
approved these changes
Mar 14, 2026
Collaborator
rwmjhb
left a comment
There was a problem hiding this comment.
Thanks for the focused fix.
I reproduced the runtime failure when installs omit peer dependencies, and declaring apache-arrow directly closes that gap cleanly. Merging this now.
caspian-coder
added a commit
to thepetshark/memory-lancedb-pro
that referenced
this pull request
Mar 16, 2026
Merged 43 upstream commits including: - Reflection injection sanitization (CortexReach#190) - Temporal facts/supersede semantics (CortexReach#183) - Fusion weighting fix (CortexReach#176) - Degenerate embedding guard (CortexReach#164) - TEI rerank provider (CortexReach#207) - Apache Arrow direct dependency (CortexReach#194) - Recall text cleanup - Contextual support with per-context preference tracking Resolved package.json conflict: combined upstream test suite with our adaptive-retrieval and noise-filter tests.
Papyrus0
pushed a commit
to Papyrus0/memory-lancedb-pro-fork
that referenced
this pull request
Mar 20, 2026
…w-direct-dependency fix: declare apache-arrow as a direct runtime dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Declare
apache-arrowas a direct runtime dependency ofmemory-lancedb-pro.Why
@lancedb/lancedbrequiresapache-arrowat runtime, but currently exposes it viapeerDependencies.That works in some regular npm environments, but it can be missed by isolated plugin installation flows.
One reproducible case is OpenClaw's plugin installer, which installs plugin dependencies with:
In that environment,
apache-arrowis not installed, and the plugin later fails when LanceDB is loaded:Declaring
apache-arrowdirectly fixes both:Changes
apache-arrow@18.1.0todependenciespackage-lock.jsonVerification
Ran in a clean container:
All passed.