Skip to content

fix: declare apache-arrow as a direct runtime dependency#194

Merged
rwmjhb merged 1 commit intoCortexReach:masterfrom
sd1114820:fix/add-apache-arrow-direct-dependency
Mar 14, 2026
Merged

fix: declare apache-arrow as a direct runtime dependency#194
rwmjhb merged 1 commit intoCortexReach:masterfrom
sd1114820:fix/add-apache-arrow-direct-dependency

Conversation

@sd1114820
Copy link
Copy Markdown
Contributor

Summary

Declare apache-arrow as a direct runtime dependency of memory-lancedb-pro.

Why

@lancedb/lancedb requires apache-arrow at runtime, but currently exposes it via peerDependencies.
That works in some regular npm environments, but it can be missed by isolated plugin installation flows.

One reproducible case is OpenClaw's plugin installer, which installs plugin dependencies with:

npm install --omit=dev --omit=peer --ignore-scripts

In that environment, apache-arrow is not installed, and the plugin later fails when LanceDB is loaded:

memory-lancedb-pro: failed to load LanceDB
Cannot find module 'apache-arrow'

Declaring apache-arrow directly fixes both:

  • regular npm installation
  • isolated OpenClaw plugin installation

Changes

  • add apache-arrow@18.1.0 to dependencies
  • add a regression assertion so the package keeps declaring it directly
  • refresh package-lock.json

Verification

Ran in a clean container:

npm ci
node test/plugin-manifest-regression.mjs
node --test test/sync-plugin-version.test.mjs

All passed.

@sd1114820 sd1114820 force-pushed the fix/add-apache-arrow-direct-dependency branch from 05ca963 to c3b553c Compare March 13, 2026 17:42
@sd1114820 sd1114820 force-pushed the fix/add-apache-arrow-direct-dependency branch from c3b553c to 1a3e0a4 Compare March 13, 2026 17:46
@rwmjhb
Copy link
Copy Markdown
Collaborator

rwmjhb commented Mar 14, 2026

感谢这个聚焦修复。

我这边复现了 --omit=peer 安装路径下缺少 apache-arrow 导致 LanceDB 运行时加载失败的问题;把它声明为直接依赖可以把这个缺口补上。

本地已在隔离目录上应用 PR 补丁并跑完整 npm test,全部通过。现在执行合并。

Copy link
Copy Markdown
Collaborator

@rwmjhb rwmjhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the focused fix.

I reproduced the runtime failure when installs omit peer dependencies, and declaring apache-arrow directly closes that gap cleanly. Merging this now.

@rwmjhb rwmjhb merged commit 065c465 into CortexReach:master Mar 14, 2026
2 of 3 checks passed
@sd1114820 sd1114820 deleted the fix/add-apache-arrow-direct-dependency branch March 14, 2026 04:50
caspian-coder added a commit to thepetshark/memory-lancedb-pro that referenced this pull request Mar 16, 2026
Merged 43 upstream commits including:
- Reflection injection sanitization (CortexReach#190)
- Temporal facts/supersede semantics (CortexReach#183)
- Fusion weighting fix (CortexReach#176)
- Degenerate embedding guard (CortexReach#164)
- TEI rerank provider (CortexReach#207)
- Apache Arrow direct dependency (CortexReach#194)
- Recall text cleanup
- Contextual support with per-context preference tracking

Resolved package.json conflict: combined upstream test suite
with our adaptive-retrieval and noise-filter tests.
Papyrus0 pushed a commit to Papyrus0/memory-lancedb-pro-fork that referenced this pull request Mar 20, 2026
…w-direct-dependency

fix: declare apache-arrow as a direct runtime dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants