fix: use input_type instead of task for NVIDIA NIM embeddings#219
Closed
vicjayjay wants to merge 1 commit intoCortexReach:masterfrom
Closed
fix: use input_type instead of task for NVIDIA NIM embeddings#219vicjayjay wants to merge 1 commit intoCortexReach:masterfrom
vicjayjay wants to merge 1 commit intoCortexReach:masterfrom
Conversation
NVIDIA NIM API now strictly validates request bodies and rejects unknown fields. The task parameter (used by Jina and others) causes a 400 error: "Extra inputs are not permitted, input: 'passage'". Route by provider: NVIDIA endpoints get input_type, others get task. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
This is pointing at a real compatibility problem, but I don’t think the current patch is complete enough to merge yet. Two gaps need to be addressed:
Please also add automated coverage for this.
Once those pieces are in place, I’m happy to take another look. |
Collaborator
|
感谢提交!NVIDIA NIM 拒绝 不过这个 PR 基于的代码已经过时了 — #216 合并后, if (this._capabilities.taskField && task) {
const value = cap.taskValueMap?.[task] ?? task;
payload[cap.taskField] = value;
}现在正确的做法是在 如果你有兴趣,欢迎基于最新 master 重新提交。 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
taskparameter causes a 400 error on NVIDIA endpointsinput_type, others gettaskRoot Cause
buildPayload()inembedder.tswas sending bothtaskandinput_typeto all providers. NVIDIA rejectstaskas unknown.Test plan