Merged
Conversation
Papyrus0
pushed a commit
to Papyrus0/memory-lancedb-pro-fork
that referenced
this pull request
Mar 20, 2026
…close() (CortexReach#221)" (CortexReach#232) revert: undo CortexReach#221 - store.close() based on incorrect root cause
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #221.
The stated root cause ("LanceDB writes are asynchronous and not flushed") is incorrect.
importEntry()alreadyawaitstable.add(), so data is persisted when the Promise resolves.table.optimize()is a compaction/index operation, not a write flush.table.close()releases file handles, not data durability.The change is not harmful but is based on a false premise and adds unnecessary code to the critical path.