fix: resolve env vars in retrieval rerank config#414
fix: resolve env vars in retrieval rerank config#414rwmjhb merged 1 commit intoCortexReach:masterfrom
Conversation
Review: APPROVE (rebase needed)The fix is correct — Before merge, please rebase onto Two things worth considering (not blocking):
|
AliceLJY
left a comment
There was a problem hiding this comment.
LGTM — changes are clean, on-topic, and well-tested. Approving.
Summary
retrieval.rerankApiKeybefore building rerank requestsretrieval.rerankEndpoint,retrieval.rerankModel, andretrieval.rerankProviderfor consistency with env-based configWhy
embedding.apiKeyalready supports${ENV_VAR}expansion, butretrieval.rerankApiKeywas passed through without explicit resolution inparsePluginConfig. In env-based OpenClaw configs this can lead to rerank auth failures or literal${JINA_API_KEY}values being propagated.Validation
node --test test/resolve-env-vars-array.test.mjs