fix(#632): two-phase upgrade - separate LLM enrichment from DB writes#645
Closed
jlin53882 wants to merge 1 commit intoCortexReach:masterfrom
Closed
fix(#632): two-phase upgrade - separate LLM enrichment from DB writes#645jlin53882 wants to merge 1 commit intoCortexReach:masterfrom
jlin53882 wants to merge 1 commit intoCortexReach:masterfrom
Conversation
…m DB writes - Extract prepareEntry() for LLM enrichment (no lock) - Extract applyEnrichedEntry() for DB writes (within single lock) - Phase 1: Promise.all for parallel LLM enrichment - Phase 2: Single runWithFileLock for all DB writes - Reduces lock contention from N to 1 per batch
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
|
與#632 開，關閉此PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes lock contention between upgrade CLI and plugin by implementing two-phase approach:
Reduces lock contention from N locks (one per entry) to 1 lock per batch.
Changes
prepareEntry()for LLM enrichment (no lock)applyEnrichedEntry()for DB writes (within single lock)Testing
test/memory-upgrader-diagnostics.test.mjspassesCloses #632
Issue: #632