fix: rebuild smart metadata on memory_update normal path (#544)#653
Open
raw34 wants to merge 1 commit intoCortexReach:masterfrom
Open
fix: rebuild smart metadata on memory_update normal path (#544)#653raw34 wants to merge 1 commit intoCortexReach:masterfrom
raw34 wants to merge 1 commit intoCortexReach:masterfrom
Conversation
…#544) The normal update path in memory_update was only updating entry.text and vector but leaving l0_abstract/l1_overview/l2_content stale. This caused recall/search to return outdated summaries after update. Based on upstream PR CortexReach#547, manually applied to resolve conflicts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
99d5465 to
604f5fa
Compare
Contributor
Author
|
CI failures are pre-existing on master — not introduced by this PR. See #657 for the fix. Once that's merged, this PR will pass CI after a rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The normal update path in memory_update was only updating entry.text and vector but leaving l0_abstract/l1_overview/l2_content stale. This caused recall/search to return outdated summaries after update.
Based on upstream PR #547, manually applied to resolve conflicts.