Skip to content

feat: Redis distributed lock for high concurrency #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jlin53882 wants to merge 13 commits into from
Closed

feat: Redis distributed lock for high concurrency #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
33dda8a
test: add phase-2 lock contention tests for memory-upgrader
jlin53882 Apr 16, 2026
c133c1a
feat: implement Phase-2 two-phase processing for Issue #632
jlin53882 Apr 16, 2026
4b23004
docs: add detailed comments explaining Phase-2 refactoring
jlin53882 Apr 16, 2026
177c082
fix: update old test to verify NEW (fixed) behavior
jlin53882 Apr 16, 2026
0322b2f
fix: 移除巢狀 lock + 修復 MR2 stale metadata 問題 (PR #639 review fixes)
jlin53882 Apr 18, 2026
20b8297
fix: 處理 F1/F3/F4/F5 維護者回饋
jlin53882 Apr 18, 2026
f405f22
fix: 讓 Test 2/3/5 實際呼叫 MemoryUpgrader 驗證
jlin53882 Apr 18, 2026
18f4ece
fix: 將 upgrader-phase2 測試加入 core-regression group (EF2)
jlin53882 Apr 18, 2026
7a5c701
merge: resolve conflict with master, keep both test entries
jlin53882 Apr 18, 2026
2a6bda1
chore: add Redis Lock tests to test script and ioredis dependency
jlin53882 Apr 18, 2026
f091ae8
feat: add ioredis dependency for Redis Lock
jlin53882 Apr 18, 2026
2f7032f
fix: 加入 upgrader-phase2 測試到允許名單 (EF2)
jlin53882 Apr 18, 2026
e22cd64
fix: add graceful fallback when Redis unavailable
jlin53882 Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"author": "win4r",
"license": "MIT",
"scripts": {
"test": "node test/embedder-error-hints.test.mjs && node test/cjk-recursion-regression.test.mjs && node test/migrate-legacy-schema.test.mjs && node --test test/config-session-strategy-migration.test.mjs && node --test test/scope-access-undefined.test.mjs && node --test test/reflection-bypass-hook.test.mjs && node --test test/smart-extractor-scope-filter.test.mjs && node --test test/store-empty-scope-filter.test.mjs && node --test test/recall-text-cleanup.test.mjs && node test/update-consistency-lancedb.test.mjs && node --test test/strip-envelope-metadata.test.mjs && node test/cli-smoke.mjs && node test/functional-e2e.mjs && node --test test/per-agent-auto-recall.test.mjs && node test/retriever-rerank-regression.mjs && node test/smart-memory-lifecycle.mjs && node test/smart-extractor-branches.mjs && node test/plugin-manifest-regression.mjs && node --test test/session-summary-before-reset.test.mjs && node --test test/sync-plugin-version.test.mjs && node test/smart-metadata-v2.mjs && node test/vector-search-cosine.test.mjs && node test/context-support-e2e.mjs && node test/temporal-facts.test.mjs && node test/memory-update-supersede.test.mjs && node test/memory-upgrader-diagnostics.test.mjs && node --test test/llm-api-key-client.test.mjs && node --test test/llm-oauth-client.test.mjs && node --test test/cli-oauth-login.test.mjs && node --test test/workflow-fork-guards.test.mjs && node --test test/clawteam-scope.test.mjs && node --test test/cross-process-lock.test.mjs && node --test test/preference-slots.test.mjs && node test/is-latest-auto-supersede.test.mjs && node --test test/temporal-awareness.test.mjs",
"test": "node test/embedder-error-hints.test.mjs && node test/cjk-recursion-regression.test.mjs && node test/migrate-legacy-schema.test.mjs && node --test test/config-session-strategy-migration.test.mjs && node --test test/scope-access-undefined.test.mjs && node --test test/reflection-bypass-hook.test.mjs && node --test test/smart-extractor-scope-filter.test.mjs && node --test test/store-empty-scope-filter.test.mjs && node --test test/recall-text-cleanup.test.mjs && node test/update-consistency-lancedb.test.mjs && node --test test/strip-envelope-metadata.test.mjs && node test/cli-smoke.mjs && node test/functional-e2e.mjs && node --test test/per-agent-auto-recall.test.mjs && node test/retriever-rerank-regression.mjs && node test/smart-memory-lifecycle.mjs && node test/smart-extractor-branches.mjs && node test/plugin-manifest-regression.mjs && node --test test/session-summary-before-reset.test.mjs && node --test test/sync-plugin-version.test.mjs && node test/smart-metadata-v2.mjs && node test/vector-search-cosine.test.mjs && node test/context-support-e2e.mjs && node test/temporal-facts.test.mjs && node test/memory-update-supersede.test.mjs && node test/memory-upgrader-diagnostics.test.mjs && node --test test/llm-api-key-client.test.mjs && node --test test/llm-oauth-client.test.mjs && node --test test/cli-oauth-login.test.mjs && node --test test/workflow-fork-guards.test.mjs && node --test test/clawteam-scope.test.mjs && node --test test/cross-process-lock.test.mjs && node --test test/preference-slots.test.mjs && node test/is-latest-auto-supersede.test.mjs && node --test test/temporal-awareness.test.mjs && node --test test/redis-lock-edge-cases.test.mjs && node --test test/redis-lock-optimized.test.mjs",
"test:cli-smoke": "node scripts/run-ci-tests.mjs --group cli-smoke",
"test:core-regression": "node scripts/run-ci-tests.mjs --group core-regression",
"test:storage-and-schema": "node scripts/run-ci-tests.mjs --group storage-and-schema",
Expand All @@ -41,6 +41,7 @@
"@lancedb/lancedb": "^0.26.2",
"@sinclair/typebox": "0.34.48",
"apache-arrow": "18.1.0",
"ioredis": "^5.10.1",
"json5": "^2.2.3",
"openai": "^6.21.0",
"proper-lockfile": "^4.1.2"
Expand All @@ -51,10 +52,10 @@
]
},
"optionalDependencies": {
"@lancedb/lancedb-darwin-x64": "^0.26.2",
"@lancedb/lancedb-darwin-arm64": "^0.26.2",
"@lancedb/lancedb-linux-x64-gnu": "^0.26.2",
"@lancedb/lancedb-darwin-x64": "^0.26.2",
"@lancedb/lancedb-linux-arm64-gnu": "^0.26.2",
"@lancedb/lancedb-linux-x64-gnu": "^0.26.2",
"@lancedb/lancedb-win32-x64-msvc": "^0.26.2"
},
"devDependencies": {
Expand Down
3 changes: 3 additions & 0 deletions scripts/ci-test-manifest.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ export const CI_TEST_MANIFEST = [
{ group: "core-regression", runner: "node", file: "test/store-serialization.test.mjs" },
{ group: "core-regression", runner: "node", file: "test/access-tracker-retry.test.mjs" },
{ group: "core-regression", runner: "node", file: "test/embedder-cache.test.mjs" },
// Issue #632 / PR #639 lock contention fix
{ group: "core-regression", runner: "node", file: "test/upgrader-phase2-lock.test.mjs" },
{ group: "core-regression", runner: "node", file: "test/upgrader-phase2-extreme.test.mjs" },
// Issue #629 batch embedding fix
{ group: "llm-clients-and-auth", runner: "node", file: "test/embedder-ollama-batch-routing.test.mjs" },
];
Expand Down
3 changes: 3 additions & 0 deletions scripts/verify-ci-test-manifest.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ const EXPECTED_BASELINE = [
{ group: "core-regression", runner: "node", file: "test/store-serialization.test.mjs" },
{ group: "core-regression", runner: "node", file: "test/access-tracker-retry.test.mjs" },
{ group: "core-regression", runner: "node", file: "test/embedder-cache.test.mjs" },
// Issue #632 / PR #639 lock contention fix
{ group: "core-regression", runner: "node", file: "test/upgrader-phase2-lock.test.mjs" },
{ group: "core-regression", runner: "node", file: "test/upgrader-phase2-extreme.test.mjs" },
];

function fail(message) {
Expand Down
Loading
Loading