Update(governance): adopt SpecSync 5 and Trust 1#10
Conversation
There was a problem hiding this comment.
Code Review
This pull request integrates SpecSync 5.0.1 and Trust 1.0.0 governance into the Hub Fledge plugin by adding configuration files, editor skills, change records, and the canonical module specification for the hub. The review feedback is highly constructive, suggesting the removal of redundant empty headers in the skill markdown files, leveraging the defined Fledge lane in verification commands to avoid duplication, and reformatting awkwardly split acceptance criteria in both the change description and state JSON files.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd3a34b851
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "timestamp": 1783954460, | |||
| "commit": "ed4c406b0e1153dfe7e2a0b3a64615c168db2509", | |||
There was a problem hiding this comment.
Re-run verification for the accepted change
This records verification against ed4c406, but the accepted tree in the reviewed commit includes later spec and requirement edits (for example specs/hub/hub.spec.md and specs/hub/requirements.md changed after that commit). When the SDD change is already marked accepted, this stale commit binding means the final contract being merged is not the one covered by the recorded fledge lanes run verify evidence; rerun specsync change verify after the final edits and record evidence for the accepted tree.
Useful? React with 👍 / 👎.
| 3. Fledge commands are spawned as argument arrays rather than interpolated shell commands. | ||
| 4. Streaming operations emit ordered events and always finish with a terminal done event. | ||
| 5. GitHub discovery is cached briefly and normalized before rendering. | ||
| 6. Browser-rendered external content is escaped or passed through the constrained markdown renderer. |
There was a problem hiding this comment.
Do not assert safe README rendering yet
When a user opens the README for a discovered repository, this invariant is currently false: the modal assigns renderMarkdown(content) to innerHTML, while public/app.js leaves raw HTML and link/image attributes unescaped before interpolation. A malicious README can therefore inject markup/script when opened, so the spec should not assert safe rendering until the renderer actually escapes or sanitizes all external content.
Useful? React with 👍 / 👎.
Summary
Test Plan