Skip to content

add jwtSecret for /v2 auth support in Countly helm chart#38

Merged
kanwarujjaval merged 2 commits into
mainfrom
canary
May 11, 2026
Merged

add jwtSecret for /v2 auth support in Countly helm chart#38
kanwarujjaval merged 2 commits into
mainfrom
canary

Conversation

@kanwarujjaval
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for configuring a JWT signing secret in the Countly Helm chart, intended to enable /v2 authentication by wiring a new jwtSecret value through the chart’s secret management paths (values-based secrets and External Secrets Operator).

Changes:

  • Introduces secrets.common.jwtSecret across reference environment YAMLs and chart values.yaml.
  • Updates the chart’s common Secret and ExternalSecret templates to optionally populate COUNTLY_CONFIG__API_JWT_SECRET.
  • Extends values.schema.json to allow the new secrets.common.jwtSecret field.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
environments/reference/secrets.example.yaml Adds jwtSecret example placeholder under secrets.common.
environments/reference/external-secrets.example.yaml Adds jwtSecret remoteRef example comment.
environments/reference/credentials-countly.yaml Documents jwtSecret as optional (needed for /v2 auth).
environments/reference/countly.yaml Adds jwtSecret to reference values (including externalSecret example).
charts/countly/values.yaml Adds secrets.common.jwtSecret and secrets.externalSecret.remoteRefs.common.jwtSecret.
charts/countly/values.schema.json Adds schema entry for secrets.common.jwtSecret.
charts/countly/templates/secret-common.yaml Conditionally renders COUNTLY_CONFIG__API_JWT_SECRET into the common Secret.
charts/countly/templates/external-secret-common.yaml Adds support for sourcing COUNTLY_CONFIG__API_JWT_SECRET from ESO remote refs or template data.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread charts/countly/templates/secret-common.yaml
@JavierGi JavierGi self-requested a review May 11, 2026 11:00
@kanwarujjaval kanwarujjaval merged commit 80d6cd1 into main May 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants