add jwtSecret for /v2 auth support in Countly helm chart#38
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for configuring a JWT signing secret in the Countly Helm chart, intended to enable /v2 authentication by wiring a new jwtSecret value through the chart’s secret management paths (values-based secrets and External Secrets Operator).
Changes:
- Introduces
secrets.common.jwtSecretacross reference environment YAMLs and chartvalues.yaml. - Updates the chart’s common Secret and ExternalSecret templates to optionally populate
COUNTLY_CONFIG__API_JWT_SECRET. - Extends
values.schema.jsonto allow the newsecrets.common.jwtSecretfield.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| environments/reference/secrets.example.yaml | Adds jwtSecret example placeholder under secrets.common. |
| environments/reference/external-secrets.example.yaml | Adds jwtSecret remoteRef example comment. |
| environments/reference/credentials-countly.yaml | Documents jwtSecret as optional (needed for /v2 auth). |
| environments/reference/countly.yaml | Adds jwtSecret to reference values (including externalSecret example). |
| charts/countly/values.yaml | Adds secrets.common.jwtSecret and secrets.externalSecret.remoteRefs.common.jwtSecret. |
| charts/countly/values.schema.json | Adds schema entry for secrets.common.jwtSecret. |
| charts/countly/templates/secret-common.yaml | Conditionally renders COUNTLY_CONFIG__API_JWT_SECRET into the common Secret. |
| charts/countly/templates/external-secret-common.yaml | Adds support for sourcing COUNTLY_CONFIG__API_JWT_SECRET from ESO remote refs or template data. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JavierGi
approved these changes
May 11, 2026
Hakandede
approved these changes
May 11, 2026
pnrgenc
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.