You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is always hard on how to name targets, for now I went with the logic that when your run: make dist or make maintainer-conf and make maintainer-clean afterwards you still endup with a clean checkout.
From naming you would expect that make distclean would cleanup after make dist but that doesn't seem to be the convention so the next logical target without creating a new one is make maintainer-clean.
From naming you would expect that make distclean would cleanup after make dist but that doesn't seem to be the convention so the next logical target without creating a new one is make maintainer-clean.
make distclean should bring you basically back to what is generated by make dist as that should (roughly) be the contents for a clean tarball. But for the conventions that we should try to adhere to, see: https://www.gnu.org/software/make/manual/html_node/Standard-Targets.html
I don't think we should take these as hard rules though, but apply where it makes sense.
From naming you would expect that make distclean would cleanup after make dist but that doesn't seem to be the convention so the next logical target without creating a new one is make maintainer-clean.
make distclean should bring you basically back to what is generated by make dist as that should (roughly) be the contents for a clean tarball. But for the conventions that we should try to adhere to, see: https://www.gnu.org/software/make/manual/html_node/Standard-Targets.html I don't think we should take these as hard rules though, but apply where it makes sense.
I checked and as this only touches maintainer-clean.
I checked the link, and we seem to do the correct thing in the distclean target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is always hard on how to name targets, for now I went with the logic that when your run:
make distormake maintainer-confandmake maintainer-cleanafterwards you still endup with a clean checkout.From naming you would expect that
make distcleanwould cleanup aftermake distbut that doesn't seem to be the convention so the next logical target without creating a new one ismake maintainer-clean.