Skip to content

Cleanup installed libraries after make dist - #3568

Open
vmcj wants to merge 1 commit into
mainfrom
make_dist_target_cleanup
Open

Cleanup installed libraries after make dist#3568
vmcj wants to merge 1 commit into
mainfrom
make_dist_target_cleanup

Conversation

@vmcj

@vmcj vmcj commented Mar 21, 2026

Copy link
Copy Markdown
Member

It is always hard on how to name targets, for now I went with the logic that when your run:
make dist or make maintainer-conf and make maintainer-clean afterwards you still endup with a clean checkout.

From naming you would expect that make distclean would cleanup after make dist but that doesn't seem to be the convention so the next logical target without creating a new one is make maintainer-clean.

@vmcj
vmcj force-pushed the make_dist_target_cleanup branch from ac218d2 to e15dfad Compare March 21, 2026 10:09
@vmcj
vmcj requested a review from eldering March 21, 2026 12:43
@vmcj
vmcj force-pushed the make_dist_target_cleanup branch from e771d14 to e15dfad Compare March 21, 2026 16:44
Comment thread webapp/Makefile Outdated
@eldering

eldering commented Jul 9, 2026

Copy link
Copy Markdown
Member

From naming you would expect that make distclean would cleanup after make dist but that doesn't seem to be the convention so the next logical target without creating a new one is make maintainer-clean.

make distclean should bring you basically back to what is generated by make dist as that should (roughly) be the contents for a clean tarball. But for the conventions that we should try to adhere to, see:
https://www.gnu.org/software/make/manual/html_node/Standard-Targets.html
I don't think we should take these as hard rules though, but apply where it makes sense.

Comment thread webapp/Makefile Outdated
@vmcj
vmcj requested a review from meisterT July 9, 2026 19:41
@vmcj
vmcj force-pushed the make_dist_target_cleanup branch from 28173ee to 60d8ec4 Compare July 11, 2026 08:37
@vmcj

vmcj commented Jul 11, 2026

Copy link
Copy Markdown
Member Author

From naming you would expect that make distclean would cleanup after make dist but that doesn't seem to be the convention so the next logical target without creating a new one is make maintainer-clean.

make distclean should bring you basically back to what is generated by make dist as that should (roughly) be the contents for a clean tarball. But for the conventions that we should try to adhere to, see: https://www.gnu.org/software/make/manual/html_node/Standard-Targets.html I don't think we should take these as hard rules though, but apply where it makes sense.

I checked and as this only touches maintainer-clean.

I checked the link, and we seem to do the correct thing in the distclean target.

@vmcj
vmcj force-pushed the make_dist_target_cleanup branch from 60d8ec4 to e157f59 Compare August 23, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants