Add JetBrains Qodana test in CI - #3610
Open
vmcj wants to merge 144 commits into
Open
Conversation
vmcj
force-pushed
the
qodana_second_try
branch
7 times, most recently
from
April 6, 2026 11:46
74d50ad to
6a9eba4
Compare
Member
|
Do we actually gain anything by using this on top of all the linting that we already do? |
vmcj
force-pushed
the
qodana_second_try
branch
2 times, most recently
from
April 7, 2026 09:21
c4e20df to
86c4c54
Compare
Member
Author
It should give us the findings which PHPStorm also provides us, I think that has some good insights in performance. So it probably doesn´t add anything in your workflow but does for the people not using PHPStorm. I'm still checking if we get some good insights though, setting it up is a bit difficult. |
vmcj
force-pushed
the
qodana_second_try
branch
3 times, most recently
from
May 17, 2026 19:29
e86634b to
294799b
Compare
vmcj
force-pushed
the
qodana_second_try
branch
3 times, most recently
from
May 25, 2026 17:43
dbc3cf4 to
7c52d2a
Compare
No functional change intended. JetBrains flags this as we do document the other properties.
Found with the `Simplify chained expression` rule in Qodana.
It seems we can´t return an actual tuple as a hint although it is valid as a return type during runtime.
In this case it would still have worked as the overwritten f is the last call but if/when we extend the code we would get a different `f` when the `zip` becomes conditional.
Probably we needed qodana.yaml, see the yaml vs yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.