Global general public clarifications on public pages - #3652
Open
vmcj wants to merge 2 commits into
Open
Conversation
vmcj
changed the title
vmcj
force-pushed
the
public_clars
branch
3 times, most recently
from
May 31, 2026 12:13
1bee4d4 to
7abe68a
Compare
Before we linked to the 'team' page for clarifications, this duplicates that page with less information as we know less about those users such as 'seen' status etc. This required a lof of deduplication by moving the templates around. There were 2 possible solutions, moving from 'public_' to 'team_' when a team is logged on or respect the URL. The advantage of one is that teams do endup on the 'public' page we would redirect and they would get all relevant information but for jury members with a team we would prefer the route that you can see what the public would see. The change would be simple, instead of checking if the current_route starts with 'team_' we would need to check if the `team` is authenticated and select on that.
To do this properly we need to think about how to get those cleanly, a lot of data gathering is now handled by DOMJudgeService so the function should be reachable from there. Cleaner would be a dedicated Service which would be better in a dedicated PR as it's currently unclear if we want this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #3651 but has 1 commit which I suspect will require more discussion on:
So this does need input but should pass CI.