Initial trivial implementation of some draft problempackage spec options. - #3665
Open
vmcj wants to merge 3 commits into
Open
Initial trivial implementation of some draft problempackage spec options.#3665vmcj wants to merge 3 commits into
draft problempackage spec options.#3665vmcj wants to merge 3 commits into
Conversation
vmcj
force-pushed
the
ignored_problemspec_properties
branch
from
July 5, 2026 18:46
8bfdb85 to
bd7ebcf
Compare
vmcj
changed the title
draft problempackage spec options.
meisterT
reviewed
Jul 12, 2026
vmcj
force-pushed
the
ignored_problemspec_properties
branch
from
July 18, 2026 14:48
bd7ebcf to
7abbdb6
Compare
Member
|
Can you please rearrange the commits in a way you would like to merge them? That will make review easier |
vmcj
force-pushed
the
ignored_problemspec_properties
branch
from
July 24, 2026 20:13
640a0a5 to
b51ee1b
Compare
Member
Author
Done. |
We mostly implement the `icpc-legacy` and parts of the `legacy` & `2025-09-draft`. In the next commits more will be added together with clear warnings on parts which are not (yet) implemented.
vmcj
force-pushed
the
ignored_problemspec_properties
branch
from
August 23, 2026 07:29
b51ee1b to
3a10bc6
Compare
meisterT
reviewed
Aug 29, 2026
| $final = array_merge($final, self::parseTypes($possibleType)); | ||
| } | ||
| } else { | ||
| $final = array_merge($final, preg_split("/[\s,;]+/", $input)); |
Member
There was a problem hiding this comment.
consider using PREG_SPLIT_NO_EMPTY to avoid tripping over type: pass-fail, and similar things
| $messages['info'][] = sprintf("Problem format version '%s' support still experimental.", $version); | ||
| } elseif ($version !== 'icpc-legacy') { | ||
| // 2023-07-draft used in Unit tests | ||
| $messages['warning'][] = sprintf("Unknown problem format version '%s'.", $version); |
Member
There was a problem hiding this comment.
this should be danger, not warning
| } | ||
| } | ||
|
|
||
| if (isset($yamlData['problem_format_version'])) { |
Member
There was a problem hiding this comment.
I wonder whether this check should be one of the first checks (given that we are bailing out in some cases
| * @param array{info?: string[], warning?: string[], danger?: string[]} $messages | ||
| * @param string[] $expected | ||
| */ | ||
| private function assertProblemSpecWarning(string $version, array $messages, array $expected = ['info']): void |
Member
There was a problem hiding this comment.
do we ever pass in the 3rd argument $expected?
| $this->assertNotEmpty($messages['info']); | ||
| $this->assertStringContainsString( | ||
| sprintf("Problem format version '%s' support still experimental.", $version), | ||
| $messages['info'][0] |
Member
There was a problem hiding this comment.
Let's make this less brittle by accepting if it is in any $messages['info'], not necessarily the first one?
| } | ||
|
|
||
| #[DataProvider('problemSpecVersionProvider')] | ||
| public function testProblemPackageFormatTest(string $problemSpecificationVersion): void |
Member
There was a problem hiding this comment.
super nit: rename to testProblemPackageFormatVersions?
|
|
||
| public static function problemSpecVersionProvider(): Generator | ||
| { | ||
| yield ['2025-09-draft']; |
Member
There was a problem hiding this comment.
these are all accepted tests, should we add one negative test as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is some progress from #3664 in reworked format ready to be discussed.
I plan to implement some of the trivial parts of the different problemspecs to get discussion started on how much we want to implement. As we have people in the wild using
mainI added a warning for all problemspecs which I'm not reasonably sure of that we implement those. In other words, anything besidesicpc-legacywill get a warning on imports via the API.I did not look into uploads via the UI yet as that complicates the work quite a lot.