Skip to content

Allow verification of submissions on (contest)problem level - #3695

Draft
vmcj wants to merge 3 commits into
DOMjudge:mainfrom
vmcj:problem_validation_switch
Draft

Allow verification of submissions on (contest)problem level#3695
vmcj wants to merge 3 commits into
DOMjudge:mainfrom
vmcj:problem_validation_switch

Conversation

@vmcj

@vmcj vmcj commented Jul 28, 2026

Copy link
Copy Markdown
Member

This allows for checking of the results and already allowing for some problems when enough submissions have come in.

As suggested by @mkfuron in https://domjudge-org.slack.com/archives/CHHURFUM7/p1779496255283309

That discussion also had other options by @mpsijm which I think are different ways of looking at the problem so I suspect we should support both (or neither?).

Also added some minor fixes:
image

vmcj added 3 commits July 28, 2026 20:29
This allows for more space on the columns with text.
This way we have \w{1} + #{1} + [a-z0-9]{6} width.
This allows for checking of the results and already allowing for some
problems when enough submissions have come in.

As suggested by @mkfuron in https://domjudge-org.slack.com/archives/CHHURFUM7/p1779496255283309
@vmcj
vmcj marked this pull request as draft July 28, 2026 18:47
@cubercsl

Copy link
Copy Markdown
Contributor

BTW, this feature was brought up in #645 before, so I think someone might switch the related settings during the contest. So I think we need to test this kind of scenario.

@mpsijm

mpsijm commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Thanks for pulling me in here! It looks like there are two separate concerns:

  • This PR currently appears to move the global setting "Verification required – Is manual verification of judgings by jury required before publication?" to the problem level. This setting keeps submissions as "pending" as long as they are not manually verified.
  • During BAPC/NWERC, we always have this setting off, but still manually verify submissions after their result has already become visible (so, moving this setting to be per-problem will probably not change anything for us). However, this becomes more difficult to manage once the easier problems have been solved many times. My suggestions in https://domjudge-org.slack.com/archives/CHHURFUM7/p1779306901059579 (the message before Marc's) were ideas for improvements in this scenario 🙂

@vmcj

vmcj commented Aug 2, 2026

Copy link
Copy Markdown
Member Author
* This PR currently appears to move the global setting "Verification required – Is manual verification of judgings by jury required before publication?" to the problem level. This setting keeps submissions as "pending" as long as they are not manually verified.

Yes, I think Marc handles this different, so I first wanted to implement his suggestion and address your suggestions in a future PR as it requires a bit more work to do it cleanly/performant.

And it shouldn't move it, it should add an additional option to do it either globally or for specific problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants