Conversation
nickygerritsen
approved these changes
Sep 2, 2026
The LaTeX taken out of a document before converting it was stored on the shared extension instead of the call, so a placeholder lost during conversion left its LaTeX behind for the next document rendered in the same request.
vmcj
reviewed
Sep 7, 2026
| return preg_replace_callback( | ||
| "/$latexPlaceholder/", | ||
| fn(): string => array_shift($this->latexFound), $markdown | ||
| // A placeholder the conversion dropped leaves one behind, so do not assume there |
Member
There was a problem hiding this comment.
I'm probably stupid but if I don't know I'll not know in the future.. which conversions do we drop but not return '' so can still replace the $placeholder with?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LaTeX taken out of a document before converting it was stored on the shared extension instead of the call, so a placeholder lost during conversion left its LaTeX behind for the next document rendered in the same request.