Skip to content

Added Autosave feature#976

Open
guness wants to merge 1 commit intoDarkFlippers:devfrom
guness:dev
Open

Added Autosave feature#976
guness wants to merge 1 commit intoDarkFlippers:devfrom
guness:dev

Conversation

@guness
Copy link
Copy Markdown

@guness guness commented Mar 16, 2026

What's new

Verification

  • Go to Sub-GHz app
  • Click Read
  • Select Config
  • Make sure "Autosave" is ON
  • Return back
  • Keep reading Sub-GHZ signals.
  • Return back and ignore loss warning.
  • Click on "saved"
  • Check the contents of "Autosave" folder.

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@xMasterX
Copy link
Copy Markdown
Member

Hi, is this ported from momentum? If so, pls add original author username in PR (WillyJL) too
Code looks very very similar, but with some differences

@guness
Copy link
Copy Markdown
Author

guness commented Mar 16, 2026

Hi, is this ported from momentum? If so, pls add original author username in PR (WillyJL) too Code looks very very similar, but with some differences

Hello @xMasterX,
Honestly I don't remember. This was in my local repository for 6 months. Now I was updating my firmware and did not want to lose this code and wanted to push.

Now checking the Momentum, there is a good chance that I picked from there. However, I don't remember right now. Let me know if that is a problem. @WillyJL .

I also found the PR on Momentum (Next-Flip/Momentum-Firmware#331), it is very very likely that I picked from there. But I was using this for a while, it is a good feature to have it here too.

@WillyJL
Copy link
Copy Markdown
Contributor

WillyJL commented Mar 16, 2026

fine by me 💯

if you could Co-authored-by: WillyJL <me@willyjl.dev>, or just mention in the changelog entry as usual

@guness
Copy link
Copy Markdown
Author

guness commented Mar 17, 2026

fine by me 💯

if you could Co-authored-by: WillyJL <me@willyjl.dev>, or just mention in the changelog entry as usual

I have added to git commit, also added to what's new section above. I hope did it right.

@xMasterX
Copy link
Copy Markdown
Member

Okay, also pls do not fill Checklist (For Reviewer) because its for reviewer, not the PR author, thats my todo list, I need to test the code and other stuff, and you put checkmark 2nd time here :C

@WillyJL
Copy link
Copy Markdown
Contributor

WillyJL commented Mar 17, 2026

fine by me 💯
if you could Co-authored-by: WillyJL <me@willyjl.dev>, or just mention in the changelog entry as usual

I have added to git commit, also added to what's new section above. I hope did it right.

almost! looks like there are some spaces before it. needs to be in commit description (where you put it is fine), without spaces before it or after

Co-authored-by: WillyJL <me@willyjl.dev>
@guness
Copy link
Copy Markdown
Author

guness commented Mar 17, 2026

fine by me 💯
if you could Co-authored-by: WillyJL <me@willyjl.dev>, or just mention in the changelog entry as usual

I have added to git commit, also added to what's new section above. I hope did it right.

almost! looks like there are some spaces before it. needs to be in commit description (where you put it is fine), without spaces before it or after

Now it shows

guness and WillyJL committed

I hope this is the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants