Skip to content

Fine tune async propagation for lettuce 5 #11607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amarziali wants to merge 5 commits into
base: master
Choose a base branch
from
+6 −8
Open

Fine tune async propagation for lettuce 5 #11607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69bbddf
Fine tune async propagation for lettuce 5
amarziali Jun 9, 2026
4581fac
suggestions
amarziali Jun 9, 2026
8e62d3d
simplify the first version
amarziali Jun 10, 2026
d88c49a
remove netty promise from tests
amarziali Jun 12, 2026
0e807c1
Rework the implementation
amarziali Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...datadog/trace/instrumentation/java/concurrent/AsyncPropagatingDisableInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ public AsyncPropagatingDisableInstrumentation() {
named("io.reactivex.internal.schedulers.AbstractDirectTask");
private static final ElementMatcher<TypeDescription> JAVA_HTTP_CLIENT =
extendsClass(named("java.net.http.HttpClient"));
private static final String LETTUCE_HANDSHAKE_HANDLER =
"io.lettuce.core.protocol.RedisHandshakeHandler";

@Override
public boolean onlyMatchKnownTypes() {
Expand Down Expand Up @@ -83,7 +85,8 @@ public String[] knownMatchingTypes() {
"org.apache.activemq.broker.TransactionBroker",
"com.mongodb.internal.connection.DefaultConnectionPool$AsyncWorkManager",
"io.reactivex.internal.schedulers.AbstractDirectTask",
"jdk.internal.net.http.HttpClientImpl"
"jdk.internal.net.http.HttpClientImpl",
LETTUCE_HANDSHAKE_HANDLER
};
}

Expand Down Expand Up @@ -185,6 +188,8 @@ public void methodAdvice(MethodTransformer transformer) {
transformer.applyAdvice(
isTypeInitializer().and(isDeclaredBy(RXJAVA2_DISABLED_TYPE_INITIALIZERS)), advice);
transformer.applyAdvice(namedOneOf("sendAsync").and(isDeclaredBy(JAVA_HTTP_CLIENT)), advice);
transformer.applyAdvice(
named("channelRegistered").and(isDeclaredBy(named(LETTUCE_HANDSHAKE_HANDLER))), advice);
Comment thread
amarziali marked this conversation as resolved.
}

public static class DisableAsyncAdvice {
Expand Down
7 changes: 0 additions & 7 deletions ...a-agent/instrumentation/lettuce/lettuce-5.0/src/test/groovy/Lettuce5ClientTestBase.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,6 @@ abstract class Lettuce5ClientTestBase extends VersionedNamingTestBase {
RedisAsyncCommands<String, ?> asyncCommands
RedisCommands<String, ?> syncCommands

@Override
boolean useStrictTraceWrites() {
// latest seems leaking continuations that terminates later hence the strict trace will discard our spans.
!isLatestDepTest
}


def setup() {
redisServer.start()
println "Using redis: $redisServer.redisURI"
Expand Down