Skip to content

Embed default ruleset in helper-rust#4037

Open
cataphract wants to merge 2 commits into
masterfrom
glopes/embed-ruleset
Open

Embed default ruleset in helper-rust#4037
cataphract wants to merge 2 commits into
masterfrom
glopes/embed-ruleset

Conversation

@cataphract

@cataphract cataphract commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

To avoids some occasional errors we see where recommended.json is not found (redeployments? upgrades?)

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@cataphract cataphract requested review from a team as code owners July 8, 2026 14:03
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 8, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 4 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | System Tests: [php-fpm-8.5, default]   View in Datadog   GitLab

🧪 20 Tests failed

tests.appsec.test_automated_payment_events.Test_Automated_Payment_Events_Stripe_Default_Rules.test_payment_failure[php-fpm-8.5] from system_tests_suite   View in Datadog
KeyError: 'appsec.events.payments.integration'

self = <tests.appsec.test_automated_payment_events.Test_Automated_Payment_Events_Stripe_Default_Rules object at 0x7f1658caa4e0>

    def test_payment_failure(self):
        """R4"""
    
        def validator(span: DataDogLibrarySpan):
            assert span["meta"]["appsec.events.payments.failure.id"] == "pi_FAKE"
            assert span["metrics"]["appsec.events.payments.failure.amount"] == 1337
...
tests.appsec.test_conf.Test_ConfigurationVariables.test_enabled[php-fpm-8.5] from system_tests_suite   View in Datadog
ValueError: No appsec event validate this condition

self = <tests.appsec.test_conf.Test_ConfigurationVariables object at 0x7f1658c2aa50>

    def test_enabled(self):
        """Test DD_APPSEC_ENABLED = true"""
>       interfaces.library.assert_waf_attack(self.r_enabled)

tests/appsec/test_conf.py:28: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
...
View all failed tests

DataDog/apm-reliability/dd-trace-php | ASAN test_c with multiple observers: [8.4]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-php | test_extension_ci: [8.4]   View in Datadog   GitLab

View all 4 failed jobs.

1 Test performance regression detected

tmp/build_extension/tests/ext/priority_sampling/001-default-sampling.phpt (priority_sampling default sampling) from php.tmp.build_extension.tests.ext.priority_sampling — 4.64s (+4s, +621%)   View in Datadog

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 54.09% (+0.01%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1e4e714 | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants